From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C752AC55185 for ; Wed, 22 Apr 2020 11:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91A742076E for ; Wed, 22 Apr 2020 11:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587553429; bh=mh6KviTIlJ5Yfq+GJHAkUOq84+76MdnD8KTn8MMt++w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jea3v/R6wNDFlXH3CSVzOpQzaaytP6nyz/obfuJsuW7VJ4LhVdm9h8CWaBVz2eatb dHV2G6r6oLN2acoKtyol73zyrHkFdhpK5inV+DuoJTrmqjfw7a1tCQ7a+3T5LDrMFM TPrJbmsdvucd++RIPr5pMP+JWXtyWgdDttiPhgLA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732505AbgDVLDs (ORCPT ); Wed, 22 Apr 2020 07:03:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:45918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726414AbgDVJ70 (ORCPT ); Wed, 22 Apr 2020 05:59:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 035042076C; Wed, 22 Apr 2020 09:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549565; bh=mh6KviTIlJ5Yfq+GJHAkUOq84+76MdnD8KTn8MMt++w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U9XZoSyrqqg99FtNwNy4O6S7EF6fFtApDoirb0hu0atZiEU5Hn2qMwLGrfzASRgQ0 YUwGY3p1ETTP1cWdGw6mYj6qzo6ddsZVe94ernV4/d3A8XNcSxNHR2VUPM93uMsEqk d43pD+FB90EYYpi9P3JJDilXnXUvysWKrR9A0404= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xu Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 003/100] qlcnic: Fix bad kzalloc null test Date: Wed, 22 Apr 2020 11:55:33 +0200 Message-Id: <20200422095023.289039498@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095022.476101261@linuxfoundation.org> References: <20200422095022.476101261@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu Wang [ Upstream commit bcaeb886ade124331a6f3a5cef34a3f1484c0a03 ] In qlcnic_83xx_get_reset_instruction_template, the variable of null test is bad, so correct it. Signed-off-by: Xu Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c index 26263a192a77e..083aeca77c758 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c @@ -1724,7 +1724,7 @@ static int qlcnic_83xx_get_reset_instruction_template(struct qlcnic_adapter *p_d ahw->reset.seq_error = 0; ahw->reset.buff = kzalloc(QLC_83XX_RESTART_TEMPLATE_SIZE, GFP_KERNEL); - if (p_dev->ahw->reset.buff == NULL) + if (ahw->reset.buff == NULL) return -ENOMEM; p_buff = p_dev->ahw->reset.buff; -- 2.20.1