From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75200C5518A for ; Wed, 22 Apr 2020 10:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AE252077D for ; Wed, 22 Apr 2020 10:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549704; bh=a8LiVpgiZbCvH/rqNM3q6PKvM9u9kGxCK1QukDRwi4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=X0hwIkzoN6grfckj09D2dQGcjaQ/EpYpozfhIs/1KK24o6X8fePGOQOxw1KuXr3eb qrvYMR4phAIE7A5MDu4b1mMFgHUpVyOeav1cH9Y5ZiJCzd3nQ0t8SwKUnFl8RMXl4O dxkIqEh+MSu/uNtkAh+nslJc7PYa57a7/OV8ldBU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbgDVKBn (ORCPT ); Wed, 22 Apr 2020 06:01:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:50192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726841AbgDVKBj (ORCPT ); Wed, 22 Apr 2020 06:01:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DE2C20735; Wed, 22 Apr 2020 10:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549698; bh=a8LiVpgiZbCvH/rqNM3q6PKvM9u9kGxCK1QukDRwi4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vkDHpEHeKDFGAXmUcL4hGqjykr8cthOjBiQpM4qp+JxDeuD8wweK+MQ+O3xTyJzAV aiXK6vtNRG6VetTQ5pfDDkWKudYWIXassBsMoaL9Ig/WRbN6yO3NUyhRsEUUu+C8v6 12qQpXFkG/8NR7PrZnhWeaF4okCLh/a8MiBLViCk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Douglas Gilbert , Li Bin , "Martin K. Petersen" Subject: [PATCH 4.4 071/100] scsi: sg: add sg_remove_request in sg_common_write Date: Wed, 22 Apr 2020 11:56:41 +0200 Message-Id: <20200422095035.973504996@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095022.476101261@linuxfoundation.org> References: <20200422095022.476101261@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Bin commit 849f8583e955dbe3a1806e03ecacd5e71cce0a08 upstream. If the dxfer_len is greater than 256M then the request is invalid and we need to call sg_remove_request in sg_common_write. Link: https://lore.kernel.org/r/1586777361-17339-1-git-send-email-huawei.libin@huawei.com Fixes: f930c7043663 ("scsi: sg: only check for dxfer_len greater than 256M") Acked-by: Douglas Gilbert Signed-off-by: Li Bin Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/sg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -820,8 +820,10 @@ sg_common_write(Sg_fd * sfp, Sg_request "sg_common_write: scsi opcode=0x%02x, cmd_size=%d\n", (int) cmnd[0], (int) hp->cmd_len)); - if (hp->dxfer_len >= SZ_256M) + if (hp->dxfer_len >= SZ_256M) { + sg_remove_request(sfp, srp); return -EINVAL; + } k = sg_start_req(srp, cmnd); if (k) {