From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1861C5518C for ; Wed, 22 Apr 2020 11:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 830372076E for ; Wed, 22 Apr 2020 11:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587553251; bh=Hokkj9t4l0CDUQoUg6xPxXeuKWo+dJ3Dzjt1UnMNo/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fN7PSPN6q2bRvixUH+L3L0NQkFFRRsVAjnCcWXRQxj/BfWT5rqmLDqeHdw5imhFo5 GobROLv3jn5Euy2AYhodhjWDNdXm9x5InW3Vgnylv48xmAUilcY14YHoMLPEZnw/dg dt0FGMF3zM46UfHl39MMmaQwB2ubCALCnVs9QoXE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726419AbgDVKB4 (ORCPT ); Wed, 22 Apr 2020 06:01:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:50630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbgDVKBx (ORCPT ); Wed, 22 Apr 2020 06:01:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEA0320780; Wed, 22 Apr 2020 10:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549713; bh=Hokkj9t4l0CDUQoUg6xPxXeuKWo+dJ3Dzjt1UnMNo/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q66pzJpozumBfwVlEpRTrBT/G7UtVZncKkJwS2Nf5sGe+V5UutlFNaU8Dut3cA2+m HrpL0F++77khQNbpGYcIb/S6FjK65QHPCDLnEROG0yHacE8TarbfSG+RQGO3BRa/RG V3P5+d8de/eod/LdAbOUvIUC9v1PdQ0tqa4/CIrs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Dedy Lansky , Maya Erez , Kalle Valo , Lee Jones Subject: [PATCH 4.4 077/100] wil6210: fix temperature debugfs Date: Wed, 22 Apr 2020 11:56:47 +0200 Message-Id: <20200422095036.949134012@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095022.476101261@linuxfoundation.org> References: <20200422095022.476101261@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dedy Lansky [ Upstream commit 6d9eb7ebae3d7e951bc0999235ae7028eb4cae4f ] For negative temperatures, "temp" debugfs is showing wrong values. Use signed types so proper calculations is done for sub zero temperatures. Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez Signed-off-by: Kalle Valo Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/wil6210/debugfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -1088,7 +1088,7 @@ static const struct file_operations fops }; /*---------temp------------*/ -static void print_temp(struct seq_file *s, const char *prefix, u32 t) +static void print_temp(struct seq_file *s, const char *prefix, s32 t) { switch (t) { case 0: @@ -1096,7 +1096,8 @@ static void print_temp(struct seq_file * seq_printf(s, "%s N/A\n", prefix); break; default: - seq_printf(s, "%s %d.%03d\n", prefix, t / 1000, t % 1000); + seq_printf(s, "%s %s%d.%03d\n", prefix, (t < 0 ? "-" : ""), + abs(t / 1000), abs(t % 1000)); break; } } @@ -1104,7 +1105,7 @@ static void print_temp(struct seq_file * static int wil_temp_debugfs_show(struct seq_file *s, void *data) { struct wil6210_priv *wil = s->private; - u32 t_m, t_r; + s32 t_m, t_r; int rc = wmi_get_temperature(wil, &t_m, &t_r); if (rc) {