From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CA6C55189 for ; Wed, 22 Apr 2020 10:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 919F72071E for ; Wed, 22 Apr 2020 10:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550364; bh=ItN11y+WxepZrDCfpTynFPnBVdMVdz9XD8CthUf6dbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=X2zUOd3nE/9D/1iU/wvq2OA0vRMTG0MQiPSSJzyl2+VVJjDUaFtUYAcAI6UmaF9/3 5ak6dmzySxJBaasPUUpUKgNoNjkruxvo+Wu86Ve39qivJJ+3UHPfr4qj/LHa+llHyp W3AG29PzSnMLZf1534fw+jZ7jtLcU/bWOsXQTPEY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729020AbgDVKMm (ORCPT ); Wed, 22 Apr 2020 06:12:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:45504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729333AbgDVKM1 (ORCPT ); Wed, 22 Apr 2020 06:12:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 548E52071E; Wed, 22 Apr 2020 10:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550346; bh=ItN11y+WxepZrDCfpTynFPnBVdMVdz9XD8CthUf6dbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CSMLX9AsiUBTDtMHy3hV31sh9JLiyeJ6NHQHoRHJt1a0+vqRZEywPTDi50z3rQtCt tm41WKh48DjfGEtWFaKX6p6Lso+zvu0EUppzPFBYjuWDRpxicc5IwM9CIPgD4TbGQE r6FfjMOKD5U6BDB8r6Nj0l7Hu5btX5gLJkgjWsPg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wang Wenhu , "David S. Miller" Subject: [PATCH 4.14 110/199] net: qrtr: send msgs from local of same id as broadcast Date: Wed, 22 Apr 2020 11:57:16 +0200 Message-Id: <20200422095108.702699277@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Wenhu [ Upstream commit 6dbf02acef69b0742c238574583b3068afbd227c ] If the local node id(qrtr_local_nid) is not modified after its initialization, it equals to the broadcast node id(QRTR_NODE_BCAST). So the messages from local node should not be taken as broadcast and keep the process going to send them out anyway. The definitions are as follow: static unsigned int qrtr_local_nid = NUMA_NO_NODE; Fixes: fdf5fd397566 ("net: qrtr: Broadcast messages only from control port") Signed-off-by: Wang Wenhu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/qrtr/qrtr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -710,20 +710,21 @@ static int qrtr_sendmsg(struct socket *s node = NULL; if (addr->sq_node == QRTR_NODE_BCAST) { - enqueue_fn = qrtr_bcast_enqueue; - if (addr->sq_port != QRTR_PORT_CTRL) { + if (addr->sq_port != QRTR_PORT_CTRL && + qrtr_local_nid != QRTR_NODE_BCAST) { release_sock(sk); return -ENOTCONN; } + enqueue_fn = qrtr_bcast_enqueue; } else if (addr->sq_node == ipc->us.sq_node) { enqueue_fn = qrtr_local_enqueue; } else { - enqueue_fn = qrtr_node_enqueue; node = qrtr_node_lookup(addr->sq_node); if (!node) { release_sock(sk); return -ECONNRESET; } + enqueue_fn = qrtr_node_enqueue; } plen = (len + 3) & ~3;