From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6E7C55186 for ; Wed, 22 Apr 2020 10:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3F742073A for ; Wed, 22 Apr 2020 10:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587552580; bh=fhMCzs+5oAeNDilCXNjN57Y84x/pplV7/I0kKxgTNjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qIFFB9ShSf6L5Dt3YpLDuMwVLGsoaJcauXPNr9tnhh/nb45hJBAyyzUYYKZYI2b5k VWsewm0dSL7s2r3KPwJIod5bIS5wiydPCujtVBKCl3wNncxa2kdL3UNtSXJktyPiBq pRc+wYtkqn7UInEbqZXv74EdEPmTXNPtzcMZgyiU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729424AbgDVKNH (ORCPT ); Wed, 22 Apr 2020 06:13:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:46252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729375AbgDVKMw (ORCPT ); Wed, 22 Apr 2020 06:12:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D0C282070B; Wed, 22 Apr 2020 10:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550371; bh=fhMCzs+5oAeNDilCXNjN57Y84x/pplV7/I0kKxgTNjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o+Kr4FZt1hStmVhdQZ1QKKx+VD4VCFMiuWS1Z7ylcAU0OMLP7Ip8+bg/Tnyn2PUCh Dlc+nbt+xhrn+8qbmxUwjjoUx4NmvvpsOiTipdBvIad0S4pq+TlPfWuN7Hec2VAZRn KKoCKbibe3rmIwyqawQVIWhy73VSEc+73uZAEVDA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Cezary Rojewski , Pierre-Louis Bossart , Mark Brown Subject: [PATCH 4.14 119/199] ASoC: Intel: mrfld: return error codes when an error occurs Date: Wed, 22 Apr 2020 11:57:25 +0200 Message-Id: <20200422095109.520131013@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King commit 3025571edd9df653e1ad649f0638368a39d1bbb5 upstream. Currently function sst_platform_get_resources always returns zero and error return codes set by the function are never returned. Fix this by returning the error return code in variable ret rather than the hard coded zero. Addresses-Coverity: ("Unused value") Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part") Signed-off-by: Colin Ian King Acked-by: Cezary Rojewski Acked-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20200208220720.36657-1-colin.king@canonical.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/atom/sst/sst_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/intel/atom/sst/sst_pci.c +++ b/sound/soc/intel/atom/sst/sst_pci.c @@ -107,7 +107,7 @@ static int sst_platform_get_resources(st dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram); do_release_regions: pci_release_regions(pci); - return 0; + return ret; } /*