From: Vinod Koul <vkoul@kernel.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: "Mathias Nyman" <mathias.nyman@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"John Stultz" <john.stultz@linaro.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Andreas Böhler" <dev@aboehler.at>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 3/5] usb: xhci: Add support for Renesas controller with memory
Date: Thu, 23 Apr 2020 20:01:27 +0530 [thread overview]
Message-ID: <20200423143127.GK72691@vkoul-mobl> (raw)
In-Reply-To: <f61fbae0-28c5-c7ad-383f-2017a9e8597d@linux.intel.com>
On 23-04-20, 17:07, Mathias Nyman wrote:
> On 14.4.2020 19.41, Vinod Koul wrote:
> > Some rensas controller like uPD720201 and uPD720202 need firmware to be
> > loaded. Add these devices in table and invoke renesas firmware loader
> > functions to check and load the firmware into device memory when
> > required.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/usb/host/xhci-pci.c | 33 +++++++++++++++++++++++++++++++++
> > drivers/usb/host/xhci.h | 1 +
> > 2 files changed, 34 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index b6c2f5c530e3..11521e2e1720 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -15,6 +15,7 @@
> >
> > #include "xhci.h"
> > #include "xhci-trace.h"
> > +#include "xhci-pci.h"
> >
> > #define SSIC_PORT_NUM 2
> > #define SSIC_PORT_CFG2 0x880c
> > @@ -328,6 +329,21 @@ static int xhci_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
> > int retval;
> > struct xhci_hcd *xhci;
> > struct usb_hcd *hcd;
> > + struct xhci_driver_data *driver_data;
> > +
> > + driver_data = (struct xhci_driver_data *)id->driver_data;
> > +
> > + if (driver_data && driver_data->quirks & XHCI_RENESAS_FW_QUIRK) {
> > + retval = renesas_xhci_pci_probe(dev, id);
> > + switch (retval) {
> > + case 0: /* fw check success, continue */
> > + break;
> > + case 1: /* fw will be loaded by async load */
> > + return 0;
>
> This is no longer true, right?
Correct.
> To me it looks like renesas_xhci_pci_probe() returns 0 on success, both if
> firmware was already running or if successfully loaded, and negative on error
Yes now it does that and I will update this part..
>
> While changing this the function name "renesas_xhci_pci_probe()" should be
> changed as well. This isn't anymore a separate firmware loading driver, just a
> a lot of renesas firmware loading code.
>
> You could call renesas_xhci_check_request_fw() directly instead:
>
> if (driver_data && driver_data->quirks & XHCI_RENESAS_FW_QUIRK) {
> retval = renesas_xhci_check_request_fw(dev, id);
> if (retval)
> return retval;
> }
Yes I can remove this layer and directly invoke the internal function..
Thanks for the comments
--
~Vinod
next prev parent reply other threads:[~2020-04-23 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 16:41 [PATCH v9 0/5] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2020-04-14 16:41 ` [PATCH v9 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe Vinod Koul
2020-04-14 16:41 ` [PATCH v9 2/5] usb: renesas-xhci: Add the renesas xhci driver Vinod Koul
2020-04-25 9:43 ` kbuild test robot
2020-04-14 16:41 ` [PATCH v9 3/5] usb: xhci: Add support for Renesas controller with memory Vinod Koul
2020-04-23 14:07 ` Mathias Nyman
2020-04-23 14:31 ` Vinod Koul [this message]
2020-04-14 16:41 ` [PATCH v9 4/5] usb: renesas-xhci: Add ROM loader for uPD720201 Vinod Koul
2020-04-14 16:41 ` [PATCH v9 5/5] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
2020-04-14 22:27 ` [PATCH v9 0/5] usb: xhci: Add support for Renesas USB controllers John Stultz
2020-04-23 13:10 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423143127.GK72691@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=dev@aboehler.at \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).