linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <vesa.jaaskelainen@vaisala.com>
To: op-tee@lists.trustedfirmware.org,
	Jens Wiklander <jens.wiklander@linaro.org>
Cc: "Rijo Thomas" <Rijo-john.Thomas@amd.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	"Devaraj Rangasamy" <Devaraj.Rangasamy@amd.com>,
	"Hongbo Yao" <yaohongbo@huawei.com>,
	"Colin Ian King" <colin.king@canonical.com>,
	linux-kernel@vger.kernel.org,
	"Vesa Jääskeläinen" <vesa.jaaskelainen@vaisala.com>
Subject: [PATCH 2/3] tee: optee: Add support for session login client UUID generation
Date: Thu, 23 Apr 2020 18:17:00 +0300	[thread overview]
Message-ID: <20200423151701.111231-3-vesa.jaaskelainen@vaisala.com> (raw)
In-Reply-To: <20200423151701.111231-1-vesa.jaaskelainen@vaisala.com>

Adds support for client UUID generation for OP-TEE. For group based session
logins membership is verified.

Signed-off-by: Vesa Jääskeläinen <vesa.jaaskelainen@vaisala.com>
---
 drivers/tee/optee/call.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c
index cf2367ba08d6..dbed3f480dc0 100644
--- a/drivers/tee/optee/call.c
+++ b/drivers/tee/optee/call.c
@@ -233,9 +233,13 @@ int optee_open_session(struct tee_context *ctx,
 	msg_arg->params[1].attr = OPTEE_MSG_ATTR_TYPE_VALUE_INPUT |
 				  OPTEE_MSG_ATTR_META;
 	memcpy(&msg_arg->params[0].u.value, arg->uuid, sizeof(arg->uuid));
-	memcpy(&msg_arg->params[1].u.value, arg->uuid, sizeof(arg->clnt_uuid));
 	msg_arg->params[1].u.value.c = arg->clnt_login;
 
+	rc = tee_session_calc_client_uuid((uuid_t *)&msg_arg->params[1].u.value,
+					  arg->clnt_login, arg->clnt_uuid);
+	if (rc)
+		goto out;
+
 	rc = optee_to_msg_param(msg_arg->params + 2, arg->num_params, param);
 	if (rc)
 		goto out;
-- 
2.17.1


  parent reply	other threads:[~2020-04-23 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 15:16 [PATCH 0/3] tee: add support for session's client UUID generation Vesa Jääskeläinen
2020-04-23 15:16 ` [PATCH 1/3] " Vesa Jääskeläinen
2020-04-23 17:35   ` Dan Carpenter
2020-04-25  6:16     ` Vesa Jääskeläinen
2020-04-25  9:24       ` Dan Carpenter
2020-04-23 15:17 ` Vesa Jääskeläinen [this message]
2020-04-23 15:17 ` [PATCH 3/3] [RFC] tee: add support for app id for " Vesa Jääskeläinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423151701.111231-3-vesa.jaaskelainen@vaisala.com \
    --to=vesa.jaaskelainen@vaisala.com \
    --cc=Devaraj.Rangasamy@amd.com \
    --cc=Rijo-john.Thomas@amd.com \
    --cc=colin.king@canonical.com \
    --cc=dan.carpenter@oracle.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=yaohongbo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).