From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: madhuparnabhowmik10@gmail.com, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
andrianov@ispras.ru, ldv-project@linuxtesting.org
Subject: Re: [PATCH] drivers: dma: pch_dma.c: Avoid data race between probe and irq handler
Date: Thu, 23 Apr 2020 23:43:35 +0530 [thread overview]
Message-ID: <20200423181334.GA23094@madhuparna-HP-Notebook> (raw)
In-Reply-To: <20200423061935.GV72691@vkoul-mobl>
On Thu, Apr 23, 2020 at 11:49:35AM +0530, Vinod Koul wrote:
> On 16-04-20, 11:53, madhuparnabhowmik10@gmail.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> >
> > pd->dma.dev is read in irq handler pd_irq().
> > However, it is set to pdev->dev after request_irq().
> > Therefore, set pd->dma.dev to pdev->dev before request_irq() to
> > avoid data race between pch_dma_probe() and pd_irq().
>
> Please use the right subsystem tag for patch. You can find that using
> git log on the respective subsystem, in this case it would have told you
> that it is dmaengine.
>
Sure, I will take care of this.
> I have fixed that up and applied it, thanks for the patch
>
Thank you,
Madhuparna
> --
> ~Vinod
prev parent reply other threads:[~2020-04-23 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 6:23 [PATCH] drivers: dma: pch_dma.c: Avoid data race between probe and irq handler madhuparnabhowmik10
2020-04-23 6:19 ` Vinod Koul
2020-04-23 18:13 ` Madhuparna Bhowmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423181334.GA23094@madhuparna-HP-Notebook \
--to=madhuparnabhowmik10@gmail.com \
--cc=andrianov@ispras.ru \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).