From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF722C2BA1A for ; Fri, 24 Apr 2020 23:50:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 927D420781 for ; Fri, 24 Apr 2020 23:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726169AbgDXXuM (ORCPT ); Fri, 24 Apr 2020 19:50:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgDXXuM (ORCPT ); Fri, 24 Apr 2020 19:50:12 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61A22C09B049; Fri, 24 Apr 2020 16:50:12 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 155BF14F4BE2C; Fri, 24 Apr 2020 16:50:12 -0700 (PDT) Date: Fri, 24 Apr 2020 16:50:11 -0700 (PDT) Message-Id: <20200424.165011.1738374030598735767.davem@davemloft.net> To: opendmb@gmail.com Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: bcmgenet: suppress warnings on failed Rx SKB allocations From: David Miller In-Reply-To: <1587682931-38636-1-git-send-email-opendmb@gmail.com> References: <1587682931-38636-1-git-send-email-opendmb@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 Apr 2020 16:50:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Doug Berger Date: Thu, 23 Apr 2020 16:02:11 -0700 > The driver is designed to drop Rx packets and reclaim the buffers > when an allocation fails, and the network interface needs to safely > handle this packet loss. Therefore, an allocation failure of Rx > SKBs is relatively benign. > > However, the output of the warning message occurs with a high > scheduling priority that can cause excessive jitter/latency for > other high priority processing. > > This commit suppresses the warning messages to prevent scheduling > problems while retaining the failure count in the statistics of > the network interface. > > Signed-off-by: Doug Berger Applied.