From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C895EC54FCB for ; Fri, 24 Apr 2020 17:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF60520704 for ; Fri, 24 Apr 2020 17:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727091AbgDXR73 (ORCPT ); Fri, 24 Apr 2020 13:59:29 -0400 Received: from bmailout1.hostsharing.net ([83.223.95.100]:32783 "EHLO bmailout1.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726793AbgDXR73 (ORCPT ); Fri, 24 Apr 2020 13:59:29 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 370373000481D; Fri, 24 Apr 2020 19:59:24 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 0D2F6DF726; Fri, 24 Apr 2020 19:59:23 +0200 (CEST) Date: Fri, 24 Apr 2020 19:59:23 +0200 From: Lukas Wunner To: William Breathitt Gray Cc: Andy Shevchenko , Syed Nayyar Waris , akpm@linux-foundation.org, arnd@arndb.de, Linus Walleij , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] bitops: Introduce the the for_each_set_clump macro Message-ID: <20200424175923.4f5y7xfp4w2wlm7b@wunner.de> References: <20200424122521.GA5552@syed> <20200424141037.ersebbfe7xls37be@wunner.de> <20200424150058.xadjxaga3csh3br6@wunner.de> <20200424150828.GA5034@icarus> <20200424163410.GD185537@smile.fi.intel.com> <20200424163904.GA7742@icarus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200424163904.GA7742@icarus> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 24, 2020 at 12:42:00PM -0400, William Breathitt Gray wrote: > Within this patchset the only non-8-bit users are gpio-thunderx and > gpio-xilinix. The gpio-xilinx has configurable port widths so in some > instances it can behave like the 8-bit users, but not always. > > If you want to keep the existing for_each_set_clump8 and related > functions, ignore [PATCH 3/6] and [PATCH 4/6]. That should allow this > patchset to be just an introduction of the new generic functions without > affecting the existing 8-bit users. Yes I don't mind the changes to gpio-thunderx and gpio-xilinx at all but please leave the 8-bit users as they are wherever possible. Actually my concern is not just performance but the existing 8-bit variant is simpler to understand than the generic variant, making it easier to follow the code in the drivers. Thanks, Lukas