From: "Michael Büsch" <m@bues.ch>
To: John Oldman <john.oldman@polehill.co.uk>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] :ssb sprom.c: Fixed block comments coding style issues
Date: Sat, 25 Apr 2020 01:05:05 +0200 [thread overview]
Message-ID: <20200425010505.586bbad4@wiggum> (raw)
In-Reply-To: <20200424175043.16261-1-john.oldman@polehill.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
On Fri, 24 Apr 2020 18:50:43 +0100
John Oldman <john.oldman@polehill.co.uk> wrote:
> Fixed coding style issues
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> drivers/ssb/sprom.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index 52d2e0f33be7..42d620cee8a9 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -78,7 +78,8 @@ ssize_t ssb_attr_sprom_show(struct ssb_bus *bus, char *buf,
>
> /* Use interruptible locking, as the SPROM write might
> * be holding the lock for several seconds. So allow userspace
> - * to cancel operation. */
> + * to cancel operation.
> + */
> err = -ERESTARTSYS;
> if (mutex_lock_interruptible(&bus->sprom_mutex))
> goto out_kfree;
> @@ -121,7 +122,8 @@ ssize_t ssb_attr_sprom_store(struct ssb_bus *bus,
>
> /* Use interruptible locking, as the SPROM write might
> * be holding the lock for several seconds. So allow userspace
> - * to cancel operation. */
> + * to cancel operation.
> + */
> err = -ERESTARTSYS;
> if (mutex_lock_interruptible(&bus->sprom_mutex))
> goto out_kfree;
> @@ -188,9 +190,11 @@ int ssb_fill_sprom_with_fallback(struct ssb_bus *bus, struct ssb_sprom *out)
> bool ssb_is_sprom_available(struct ssb_bus *bus)
> {
> /* status register only exists on chipcomon rev >= 11 and we need check
> - for >= 31 only */
> + * for >= 31 only
> + */
> /* this routine differs from specs as we do not access SPROM directly
> - on PCMCIA */
> + * on PCMCIA
> + */
> if (bus->bustype == SSB_BUSTYPE_PCI &&
> bus->chipco.dev && /* can be unavailable! */
> bus->chipco.dev->id.revision >= 31)
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-24 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 17:50 [PATCH] :ssb sprom.c: Fixed block comments coding style issues John Oldman
2020-04-24 23:05 ` Michael Büsch [this message]
2020-04-27 5:26 ` Kalle Valo
2020-04-28 9:01 ` [PATCH] ssb: sprom: fix " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425010505.586bbad4@wiggum \
--to=m@bues.ch \
--cc=john.oldman@polehill.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).