linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Joe Perches <joe@perches.com>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v4 6/7] kernel.h: Split out panic and oops helpers
Date: Sat, 25 Apr 2020 01:27:04 +0800	[thread overview]
Message-ID: <202004250131.iVxgqjFF%lkp@intel.com> (raw)
In-Reply-To: <20200422125201.37618-6-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 9794 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20200423]
[cannot apply to tip/locking/core rcu/dev linus/master tip/x86/core v5.7-rc2 v5.7-rc1 v5.6 v5.7-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/drm-shmobile-Reduce-include-dependencies/20200424-044529
base:    aefe184e814492e36b2ca350c1522bd71b09b520
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/char/ipmi/ipmi_msghandler.c: In function 'ipmi_init_msghandler':
>> drivers/char/ipmi/ipmi_msghandler.c:5145:34: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
    5145 |  atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
         |                                  ^~~~~~~~~~~~~~~~~~~
         |                                  reboot_notifier_list
   drivers/char/ipmi/ipmi_msghandler.c:5145:34: note: each undeclared identifier is reported only once for each function it appears in
   drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
   drivers/char/ipmi/ipmi_msghandler.c:5172:37: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
    5172 |   atomic_notifier_chain_unregister(&panic_notifier_list,
         |                                     ^~~~~~~~~~~~~~~~~~~
         |                                     reboot_notifier_list
--
   drivers/misc/pvpanic.c: In function 'pvpanic_mmio_probe':
>> drivers/misc/pvpanic.c:156:34: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     156 |  atomic_notifier_chain_register(&panic_notifier_list,
         |                                  ^~~~~~~~~~~~~~~~~~~
         |                                  reboot_notifier_list
   drivers/misc/pvpanic.c:156:34: note: each undeclared identifier is reported only once for each function it appears in
   drivers/misc/pvpanic.c: In function 'pvpanic_mmio_remove':
   drivers/misc/pvpanic.c:165:36: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     165 |  atomic_notifier_chain_unregister(&panic_notifier_list,
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    reboot_notifier_list
--
   drivers/remoteproc/remoteproc_core.c: In function 'rproc_init_panic':
>> drivers/remoteproc/remoteproc_core.c:2383:34: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
    2383 |  atomic_notifier_chain_register(&panic_notifier_list, &rproc_panic_nb);
         |                                  ^~~~~~~~~~~~~~~~~~~
         |                                  reboot_notifier_list
   drivers/remoteproc/remoteproc_core.c:2383:34: note: each undeclared identifier is reported only once for each function it appears in
   drivers/remoteproc/remoteproc_core.c: In function 'rproc_exit_panic':
   drivers/remoteproc/remoteproc_core.c:2388:36: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
    2388 |  atomic_notifier_chain_unregister(&panic_notifier_list, &rproc_panic_nb);
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    reboot_notifier_list
--
   drivers/power/reset/ltc2952-poweroff.c: In function 'ltc2952_poweroff_probe':
>> drivers/power/reset/ltc2952-poweroff.c:276:34: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     276 |  atomic_notifier_chain_register(&panic_notifier_list,
         |                                  ^~~~~~~~~~~~~~~~~~~
         |                                  reboot_notifier_list
   drivers/power/reset/ltc2952-poweroff.c:276:34: note: each undeclared identifier is reported only once for each function it appears in
   drivers/power/reset/ltc2952-poweroff.c: In function 'ltc2952_poweroff_remove':
   drivers/power/reset/ltc2952-poweroff.c:290:36: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     290 |  atomic_notifier_chain_unregister(&panic_notifier_list,
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    reboot_notifier_list
--
   drivers/leds/trigger/ledtrig-heartbeat.c: In function 'heartbeat_trig_init':
>> drivers/leds/trigger/ledtrig-heartbeat.c:192:35: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     192 |   atomic_notifier_chain_register(&panic_notifier_list,
         |                                   ^~~~~~~~~~~~~~~~~~~
         |                                   reboot_notifier_list
   drivers/leds/trigger/ledtrig-heartbeat.c:192:35: note: each undeclared identifier is reported only once for each function it appears in
   drivers/leds/trigger/ledtrig-heartbeat.c: In function 'heartbeat_trig_exit':
   drivers/leds/trigger/ledtrig-heartbeat.c:202:36: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     202 |  atomic_notifier_chain_unregister(&panic_notifier_list,
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    reboot_notifier_list
--
   drivers/leds/trigger/ledtrig-activity.c: In function 'activity_init':
>> drivers/leds/trigger/ledtrig-activity.c:249:35: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     249 |   atomic_notifier_chain_register(&panic_notifier_list,
         |                                   ^~~~~~~~~~~~~~~~~~~
         |                                   reboot_notifier_list
   drivers/leds/trigger/ledtrig-activity.c:249:35: note: each undeclared identifier is reported only once for each function it appears in
   drivers/leds/trigger/ledtrig-activity.c: In function 'activity_exit':
   drivers/leds/trigger/ledtrig-activity.c:259:36: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
     259 |  atomic_notifier_chain_unregister(&panic_notifier_list,
         |                                    ^~~~~~~~~~~~~~~~~~~
         |                                    reboot_notifier_list
--
   drivers/leds/trigger/ledtrig-panic.c: In function 'ledtrig_panic_init':
>> drivers/leds/trigger/ledtrig-panic.c:66:34: error: 'panic_notifier_list' undeclared (first use in this function); did you mean 'reboot_notifier_list'?
      66 |  atomic_notifier_chain_register(&panic_notifier_list,
         |                                  ^~~~~~~~~~~~~~~~~~~
         |                                  reboot_notifier_list
   drivers/leds/trigger/ledtrig-panic.c:66:34: note: each undeclared identifier is reported only once for each function it appears in

vim +5145 drivers/char/ipmi/ipmi_msghandler.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  5128  
^1da177e4c3f41 Linus Torvalds 2005-04-16  5129  static int ipmi_init_msghandler(void)
^1da177e4c3f41 Linus Torvalds 2005-04-16  5130  {
50c812b2b9513e Corey Minyard  2006-03-26  5131  	int rv;
^1da177e4c3f41 Linus Torvalds 2005-04-16  5132  
913a89f009d98c Corey Minyard  2018-12-20  5133  	mutex_lock(&ipmi_interfaces_mutex);
913a89f009d98c Corey Minyard  2018-12-20  5134  	rv = ipmi_register_driver();
913a89f009d98c Corey Minyard  2018-12-20  5135  	if (rv)
913a89f009d98c Corey Minyard  2018-12-20  5136  		goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16  5137  	if (initialized)
913a89f009d98c Corey Minyard  2018-12-20  5138  		goto out;
50c812b2b9513e Corey Minyard  2006-03-26  5139  
913a89f009d98c Corey Minyard  2018-12-20  5140  	init_srcu_struct(&ipmi_interfaces_srcu);
^1da177e4c3f41 Linus Torvalds 2005-04-16  5141  
e99e88a9d2b067 Kees Cook      2017-10-16  5142  	timer_setup(&ipmi_timer, ipmi_timeout, 0);
409035e088ce15 Corey Minyard  2006-06-28  5143  	mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);
^1da177e4c3f41 Linus Torvalds 2005-04-16  5144  
e041c683412d5b Alan Stern     2006-03-27 @5145  	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
^1da177e4c3f41 Linus Torvalds 2005-04-16  5146  
913a89f009d98c Corey Minyard  2018-12-20  5147  	initialized = true;
^1da177e4c3f41 Linus Torvalds 2005-04-16  5148  
913a89f009d98c Corey Minyard  2018-12-20  5149  out:
913a89f009d98c Corey Minyard  2018-12-20  5150  	mutex_unlock(&ipmi_interfaces_mutex);
913a89f009d98c Corey Minyard  2018-12-20  5151  	return rv;
^1da177e4c3f41 Linus Torvalds 2005-04-16  5152  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  5153  

:::::: The code at line 5145 was first introduced by commit
:::::: e041c683412d5bf44dc2b109053e3b837b71742d [PATCH] Notifier chain update: API changes

:::::: TO: Alan Stern <stern@rowland.harvard.edu>
:::::: CC: Linus Torvalds <torvalds@g5.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54973 bytes --]

  parent reply	other threads:[~2020-04-24 17:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 12:51 [PATCH v4 1/7] drm: shmobile: Reduce include dependencies Andy Shevchenko
2020-04-22 12:51 ` [PATCH v4 2/7] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers Andy Shevchenko
2020-04-22 12:51 ` [PATCH v4 3/7] kernel.h: Move oops_in_progress to printk.h Andy Shevchenko
2020-04-22 12:51 ` [PATCH v4 4/7] kernel.h: Split out min()/max() et al helpers Andy Shevchenko
2020-04-22 14:52   ` Joe Perches
2020-04-22 15:44     ` Andy Shevchenko
2020-04-22 15:51       ` Joe Perches
2020-04-23  9:33     ` Rasmus Villemoes
2020-04-22 12:51 ` [PATCH v4 5/7] kernel.h: Split out mathematical helpers Andy Shevchenko
2020-04-22 12:52 ` [PATCH v4 6/7] kernel.h: Split out panic and oops helpers Andy Shevchenko
2020-04-24 17:04   ` kbuild test robot
2020-04-24 17:27   ` kbuild test robot [this message]
2020-04-22 12:52 ` [PATCH v4 7/7] kernel.h: Split out might_sleep() and friends Andy Shevchenko
2020-04-24 15:49   ` kbuild test robot
2020-04-24 17:45   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202004250131.iVxgqjFF%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=joe@perches.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).