From: Greg KH <gregkh@linuxfoundation.org>
To: Suraj Upadhyay <usuraj35@gmail.com>
Cc: jerome.pouiller@silabs.com, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: wfx: cleanup long lines in data_tx.c
Date: Sat, 25 Apr 2020 12:54:32 +0200 [thread overview]
Message-ID: <20200425105432.GA2068247@kroah.com> (raw)
In-Reply-To: <20200424134834.GA19700@blackclown>
On Fri, Apr 24, 2020 at 07:18:34PM +0530, Suraj Upadhyay wrote:
> Break lines with length over 80 characters to conform
> to the linux coding style and refactor wherever necessary.
>
> Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> ---
>
> Changes in v3:
> - Changed the temporary variable name for the memzcmp statement
> to is_used. (as suggested).
> - Added a temporary ieee80211_supported_band variable to address
> the problem in wfx_get_hw_rate() more efficiently. (not
> suggested, but still).
>
> Changes in v2:
> - Introduced a temporary variable for the memzcmp statement.
> - Addressed the checkpatch problem with wfx_get_hw_rate().
> - Restored the function definition of wfx_tx_get_tx_parms
> as suggested by the reviewer.
> - Added suggested changes for req->packet_id statement.
>
> drivers/staging/wfx/data_tx.c | 40 +++++++++++++++++++++++------------
> 1 file changed, 26 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 9c1a91207dd8..717155975345 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -20,6 +20,8 @@
> static int wfx_get_hw_rate(struct wfx_dev *wdev,
> const struct ieee80211_tx_rate *rate)
> {
> +
> + struct ieee80211_supported_band *band;
> if (rate->idx < 0)
checkpatch did not complain about this change?
It should have...
Please fix that up.
thanks,
greg k-h
prev parent reply other threads:[~2020-04-25 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 13:48 [PATCH v3] staging: wfx: cleanup long lines in data_tx.c Suraj Upadhyay
2020-04-25 10:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425105432.GA2068247@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=jerome.pouiller@silabs.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usuraj35@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).