From: Sam Ravnborg <sam@ravnborg.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/panel: remove set but not used variable 'config'
Date: Sat, 25 Apr 2020 16:57:56 +0200 [thread overview]
Message-ID: <20200425145756.GG32235@ravnborg.org> (raw)
In-Reply-To: <20200417101401.19388-1-yuehaibing@huawei.com>
Hi YueHaibing
On Fri, Apr 17, 2020 at 06:14:01PM +0800, YueHaibing wrote:
> drivers/gpu/drm/panel/panel-truly-nt35597.c:493:31: warning: variable ‘config’ set but not used [-Wunused-but-set-variable]
> const struct nt35597_config *config;
> ^~~~~~
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks. Applied to drm-misc-next, so it will appear in mainline kernel
in the next merge window.
Sam
> ---
> drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
> index 012ca62bf30e..f0ad6081570f 100644
> --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
> +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
> @@ -490,9 +490,7 @@ static int truly_nt35597_panel_add(struct truly_nt35597 *ctx)
> {
> struct device *dev = ctx->dev;
> int ret, i;
> - const struct nt35597_config *config;
>
> - config = ctx->config;
> for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
> ctx->supplies[i].supply = regulator_names[i];
>
> --
> 2.17.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-25 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 10:14 [PATCH -next] drm/panel: remove set but not used variable 'config' YueHaibing
2020-04-25 14:57 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-10 2:45 [PATCH -next] drm/panel: Remove " YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425145756.GG32235@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).