From: Jonathan Cameron <jic23@kernel.org>
To: Nishant Malpani <nish.malpani25@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
alexandru.Ardelean@analog.com
Subject: Re: [PATCH 2/3] iio: accel: kxsd9-i2c: Use mod_devicetable.h and drop of_match_ptr macro
Date: Sat, 25 Apr 2020 15:36:27 +0100 [thread overview]
Message-ID: <20200425153627.668870ee@archlinux> (raw)
In-Reply-To: <20200424224439.5601-3-nish.malpani25@gmail.com>
On Sat, 25 Apr 2020 04:14:38 +0530
Nishant Malpani <nish.malpani25@gmail.com> wrote:
> Enables ACPI DSDT to probe via PRP0001 and the compatible property. Also
> removes the ifdef protections for CONFIG_OF.
>
> Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/accel/kxsd9-i2c.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> index b6f3de7ef8ea..b580d605f848 100644
> --- a/drivers/iio/accel/kxsd9-i2c.c
> +++ b/drivers/iio/accel/kxsd9-i2c.c
> @@ -2,6 +2,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/i2c.h>
> #include <linux/delay.h>
> @@ -36,15 +37,11 @@ static int kxsd9_i2c_remove(struct i2c_client *client)
> return kxsd9_common_remove(&client->dev);
> }
>
> -#ifdef CONFIG_OF
> static const struct of_device_id kxsd9_of_match[] = {
> { .compatible = "kionix,kxsd9", },
> { },
> };
> MODULE_DEVICE_TABLE(of, kxsd9_of_match);
> -#else
> -#define kxsd9_of_match NULL
> -#endif
>
> static const struct i2c_device_id kxsd9_i2c_id[] = {
> {"kxsd9", 0},
> @@ -55,7 +52,7 @@ MODULE_DEVICE_TABLE(i2c, kxsd9_i2c_id);
> static struct i2c_driver kxsd9_i2c_driver = {
> .driver = {
> .name = "kxsd9",
> - .of_match_table = of_match_ptr(kxsd9_of_match),
> + .of_match_table = kxsd9_of_match,
> .pm = &kxsd9_dev_pm_ops,
> },
> .probe = kxsd9_i2c_probe,
next prev parent reply other threads:[~2020-04-25 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 22:44 [PATCH 0/3] iio: accel: Abandon of_match_ptr macro Nishant Malpani
2020-04-24 22:44 ` [PATCH 1/3] iio: accel: dmard06: Use mod_devicetable.h and drop " Nishant Malpani
2020-04-25 14:35 ` Jonathan Cameron
2020-04-24 22:44 ` [PATCH 2/3] iio: accel: kxsd9-i2c: " Nishant Malpani
2020-04-25 14:36 ` Jonathan Cameron [this message]
2020-04-24 22:44 ` [PATCH 3/3] iio: accel: mma8452: Drop " Nishant Malpani
2020-04-25 14:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425153627.668870ee@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.Ardelean@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nish.malpani25@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).