From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709BFC55191 for ; Sun, 26 Apr 2020 08:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A2962071C for ; Sun, 26 Apr 2020 08:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726156AbgDZI3y (ORCPT ); Sun, 26 Apr 2020 04:29:54 -0400 Received: from smtpout1.mo528.mail-out.ovh.net ([46.105.34.251]:43733 "EHLO smtpout1.mo528.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbgDZI3y (ORCPT ); Sun, 26 Apr 2020 04:29:54 -0400 Received: from pro2.mail.ovh.net (unknown [10.108.1.157]) by mo528.mail-out.ovh.net (Postfix) with ESMTPS id C5AB15AE098D; Sun, 26 Apr 2020 10:29:50 +0200 (CEST) Received: from localhost (89.70.31.203) by DAG2EX1.emp2.local (172.16.2.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Sun, 26 Apr 2020 10:29:50 +0200 Date: Sun, 26 Apr 2020 10:28:25 +0200 From: Tomasz Duszynski To: Jonathan Cameron CC: Tomasz Duszynski , , , , Subject: Re: [PATCH 5/6] dt-bindings: iio: scd30: add device binding file Message-ID: <20200426082825.GA3282@arch> References: <20200422141135.86419-1-tomasz.duszynski@octakon.com> <20200422141135.86419-6-tomasz.duszynski@octakon.com> <20200425202341.53e614d8@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20200425202341.53e614d8@archlinux> X-Originating-IP: [89.70.31.203] X-ClientProxiedBy: DAG2EX2.emp2.local (172.16.2.12) To DAG2EX1.emp2.local (172.16.2.11) X-Ovh-Tracer-Id: 5079497430882606162 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepfffhvffukfhfgggtuggjihesthdtredttddtjeenucfhrhhomhepvfhomhgrshiiucffuhhsiiihnhhskhhiuceothhomhgrshiirdguuhhsiiihnhhskhhisehotghtrghkohhnrdgtohhmqeenucffohhmrghinhepuggvvhhitggvthhrvggvrdhorhhgnecukfhppedtrddtrddtrddtpdekledrjedtrdefuddrvddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehprhhovddrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehtohhmrghsiidrughushiihihnshhkihesohgtthgrkhhonhdrtghomhdprhgtphhtthhopehrohgshhdoughtsehkvghrnhgvlhdrohhrgh Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 25, 2020 at 08:23:41PM +0100, Jonathan Cameron wrote: > On Wed, 22 Apr 2020 16:11:34 +0200 > Tomasz Duszynski wrote: > > > Add SCD30 sensor binding file. > > > > Signed-off-by: Tomasz Duszynski > > --- > > .../iio/chemical/sensirion,scd30.yaml | 71 +++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > > new file mode 100644 > > index 000000000000..b092b2530c76 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > > @@ -0,0 +1,71 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license preferred with BSD for bindings. > Okay. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/chemical/sensirion,scd30.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sensirion SCD30 carbon dioxide sensor > > + > > +maintainers: > > + - Tomasz Duszynski > > + > > +description: | > > + Air quality sensor capable of measuring co2 concentration, temperature > > + and relative humidity. > > + > > +properties: > > + compatible: > > + enum: > > + - sensirion,scd30 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + vdd-supply: true > > + > > + sensirion,sel-gpios: > > + description: GPIO connected to the SEL line > > + maxItems: 1 > > + > > + sensirion,pwm-gpios: > > + description: GPIO connected to the PWM line > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - vdd-supply > > Only enable it I think in the driver. Should be fine with a stub regulator > as provided if we don't specify one in the dt binding because it's not > controllable and we are lazy. > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + # include > > + # include > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + scd30@61 { > > + compatible = "sensirion,scd30"; > > + reg = <0x61>; > > + vdd-supply = <&vdd>; > > + interrupt-parrent = <&gpio0>; > > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > + }; > > + - | > > + # include > > Why gpio? > That shouldn't be here. I have some local changes where I use sel-gpios hence this include. > > + # include > > + serial { > > + scd30 { > > + compatible = "sensirion,scd30"; > > + vdd-supply = <&vdd>; > > + interrupt-parrent = <&gpio0>; > > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > + }; > > + > > +... >