* [PATCH] power: supply: ab8500_fg: remove comparison to bool
@ 2020-04-26 9:42 Jason Yan
2020-04-28 14:02 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-04-26 9:42 UTC (permalink / raw)
To: sre, linus.walleij, linux-pm, linux-kernel; +Cc: Jason Yan
Fix the following coccicheck warning:
drivers/power/supply/ab8500_fg.c:2402:5-24: WARNING: Comparison to bool
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/power/supply/ab8500_fg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
index b96f90a82ecf..751c4f6c7487 100644
--- a/drivers/power/supply/ab8500_fg.c
+++ b/drivers/power/supply/ab8500_fg.c
@@ -2399,7 +2399,7 @@ static void ab8500_fg_reinit_work(struct work_struct *work)
struct ab8500_fg *di = container_of(work, struct ab8500_fg,
fg_reinit_work.work);
- if (di->flags.calibrate == false) {
+ if (!di->flags.calibrate) {
dev_dbg(di->dev, "Resetting FG state machine to init.\n");
ab8500_fg_clear_cap_samples(di);
ab8500_fg_calc_cap_discharge_voltage(di, true);
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: ab8500_fg: remove comparison to bool
2020-04-26 9:42 [PATCH] power: supply: ab8500_fg: remove comparison to bool Jason Yan
@ 2020-04-28 14:02 ` Linus Walleij
2020-04-28 19:20 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2020-04-28 14:02 UTC (permalink / raw)
To: Jason Yan; +Cc: Sebastian Reichel, Linux PM list, linux-kernel
On Sun, Apr 26, 2020 at 11:43 AM Jason Yan <yanaijie@huawei.com> wrote:
> Fix the following coccicheck warning:
>
> drivers/power/supply/ab8500_fg.c:2402:5-24: WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: ab8500_fg: remove comparison to bool
2020-04-28 14:02 ` Linus Walleij
@ 2020-04-28 19:20 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2020-04-28 19:20 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jason Yan, Linux PM list, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
Hi,
On Tue, Apr 28, 2020 at 04:02:31PM +0200, Linus Walleij wrote:
> On Sun, Apr 26, 2020 at 11:43 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> > Fix the following coccicheck warning:
> >
> > drivers/power/supply/ab8500_fg.c:2402:5-24: WARNING: Comparison to bool
> >
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-28 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 9:42 [PATCH] power: supply: ab8500_fg: remove comparison to bool Jason Yan
2020-04-28 14:02 ` Linus Walleij
2020-04-28 19:20 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).