From: Jonathan Cameron <jic23@kernel.org>
To: "Leslie Hsia(夏邦進_Pegatron)" <Leslie_Hsia@pegatroncorp.com>
Cc: "knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"Hermes Hsieh( 謝旻劭_Pegatron)" <Hermes_Hsieh@pegatroncorp.com>,
"jesse.sung@canonical.com" <jesse.sung@canonical.com>
Subject: Re: [PATCH] subsystem: Amplifier driver for TAS5805M,Texas instruments
Date: Sun, 26 Apr 2020 09:55:14 +0100 [thread overview]
Message-ID: <20200426095514.28aaecad@archlinux> (raw)
In-Reply-To: <754706C925201D4896E92CCAD6B38E4401F0F6B825@PTW-EX-38.PEGA.CORP.PEGATRON>
On Mon, 20 Apr 2020 06:58:17 +0000
Leslie Hsia(夏邦進_Pegatron) <Leslie_Hsia@pegatroncorp.com> wrote:
> * Author: Leslie Hsia
> * Amplifier driver for TAS5805M, initial the amplifier and set the sound's parameter.
> * Signed-off-by: Leslie Hsia <Leslie_Hsia@pegatroncorp.com<mailto:Leslie_Hsia@pegatroncorp.com>>
>
> -------------------------------------------------------------------------------------------------
>
> * Hi Jonathan,
> tas5805m only needs to be initialized via i2c port, this driver doesn't use any ALSA API,
> so we put this driver into this path
I'm still unconvinced. This is very much an audio part so people
aren't going to expect to find it in IIO. Mark?
Also please ensure next version of code is sent inline. See
Documentation/process/submitting-patches
Jonathan
>
>
>
> This e-mail and its attachment may contain information that is confidential or privileged, and are solely for the use of the individual to whom this e-mail is addressed. If you are not the intended recipient or have received it accidentally, please immediately notify the sender by reply e-mail and destroy all copies of this email and its attachment. Please be advised that any unauthorized use, disclosure, distribution or copying of this email or its attachment is strictly prohibited.
>
> 本電子郵件及其附件可能含有機密或依法受特殊管制之資訊，僅供本電子郵件之受文者使用。台端如非本電子郵件之受文者或誤收本電子郵件，請立即回覆郵件通知寄件人，並銷毀本電子郵件之所有複本及附件。任何未經授權而使用、揭露、散佈或複製本電子郵件或其附件之行為，皆嚴格禁止 。
>
next parent reply other threads:[~2020-04-26 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <754706C925201D4896E92CCAD6B38E4401F0F6B825@PTW-EX-38.PEGA.CORP.PEGATRON>
2020-04-26 8:55 ` Jonathan Cameron [this message]
[not found] <754706C925201D4896E92CCAD6B38E4401F0F733E3@PTW-EX-37.PEGA.CORP.PEGATRON>
2020-04-28 11:30 ` [PATCH] subsystem: Amplifier driver for TAS5805M,Texas instruments Mark Brown
2020-04-28 18:27 ` Leslie Hsia(夏邦進_Pegatron)
2020-04-29 12:49 ` Mark Brown
[not found] <754706C925201D4896E92CCAD6B38E4401F0F61013@PTW-EX-37.PEGA.CORP.PEGATRON>
2020-04-05 11:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200426095514.28aaecad@archlinux \
--to=jic23@kernel.org \
--cc=Hermes_Hsieh@pegatroncorp.com \
--cc=Leslie_Hsia@pegatroncorp.com \
--cc=broonie@kernel.org \
--cc=jesse.sung@canonical.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).