linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Pavel Machek <pavel@denx.de>, Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
	Lee Jones <lee.jones@linaro.org>, Jiri Slaby <jslaby@suse.cz>,
	Merlijn Wajer <merlijn@wizzup.org>,
	Peter Hurley <peter@hurleysoftware.com>,
	Sebastian Reichel <sre@kernel.org>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCHv6 0/4] n_gsm serdev support and protocol driver for droid4 modem
Date: Sun, 26 Apr 2020 16:25:20 -0700	[thread overview]
Message-ID: <20200426232520.GP37466@atomide.com> (raw)
In-Reply-To: <20200426200718.GA22980@amd>

* Pavel Machek <pavel@ucw.cz> [200426 20:08]:
> Hi!
> 
> > > > > Here's v4 set of n_gsm serdev support patches, and the related protocol
> > > > > driver for the modem found on Motorola Mapphone phones and tablets
> > > > > like droid4.
> > > > > 
> > > > > This series only adds basic character device support for the serdev
> > > > > driver. Other serdev consumer drivers for specific devices will be
> > > > > posted separately.
> > > > 
> > > > I'm still missing an architectural (design) overview here -- reviewer
> > > > time is a scarce resource.
> > > > 
> > > > I also suggested earlier that you include, at least as an RFC, one or
> > > > more of your child-device drivers so that we can see how this ends up
> > > > being used in the end (including an example devicetree).
> > > 
> > > Note that this is useful on its own: we have ofonod running on the top
> > > of this doing calls and SMSes.
> > 
> > Yup.
> > 
> > > Tony: I know you have drivers depending on this somewhere (audio
> > > routing and GPS), but I can't find them. It is not droid4-pending-v5.6
> > > AFAICT. Do you have a pointer / could you publish them somewhere?
> > 
> > Hmm they should be there in droid4-pending-v5.6 branch [0]:
> > 
> > $ git log --abbrev=12 --pretty=format:"%h (\"%s\")" \
> > 	v5.6..droid4-pending-v5.6 | grep -i -e gsm -e mot -e mdm
> > e09590a260a4 ("mfd: motmdm: Fix oops on unload of motorola-mdm")
> > f9252f9ff6bd ("mfd: motmdm: Revert bad list change")
> > d733dcaf4416 ("mfd: motmdm: Fix issue with receiving data before ddata is set")
> > 452d2b5d4c95 ("n_gsm: Build fixes for make randconfig build")
> > 6882b27ea92a ("phy: mapphone-mdm6600: Fix write timeouts with shorter GPIO toggle interval")
> > 58ff58c4b520 ("mfd: motmdm: Add basic DTMF support")
> > e92b6f30e5ae ("ASoC: audio-graph-card: Add audio mixer for motorold mdm6600")
> > c2caea5767d5 ("gnss: mot-mdm6600: Add support for Motorola Mapphone MDM6600 modem")
> > a5f73b7b06f6 ("mfd: motmdm: Add Motorola TS 27.010 serdev driver for devices like droid4")
> > 6c311d5aeb0a ("dt-bindings: mfd: motmdm: Add binding for motorola-mdm")
> > cd02274b920e ("tty: n_gsm: Add support for serdev drivers")
> > a73a48321c98 ("phy: mapphone-mdm6600: Fix timeouts by adding wake-up handling")
> 
> Here's better try at getting gnss to work on top of linux-next... but
> still no luck.

Hmm that's about all it should take. Presumably you already tried
diffing the related files against droid4-pending-v5.6 branch.

I'm moving around things to work with a generic serdev-ngsm.c driver
so I'm inbetween patches right now and don't have it working either
probably for a few more days.

Regards,

Tony

      reply	other threads:[~2020-04-26 23:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 23:27 Tony Lindgren
2020-04-21 23:27 ` [PATCH 1/4] tty: n_gsm: Add support for serdev drivers Tony Lindgren
2020-04-21 23:27 ` [PATCH 2/4] serdev: ngsm-motmdm: Add Motorola TS 27.010 serdev modem driver for droid4 Tony Lindgren
2020-04-21 23:27 ` [PATCH 3/4] dt-bindings: serdev: motmdm: Add binding for motorola-mdm Tony Lindgren
2020-04-21 23:27 ` [PATCH 4/4] ARM: dts: omap4-droid4: Enable basic modem support Tony Lindgren
2020-04-23 11:43 ` [PATCHv6 0/4] n_gsm serdev support and protocol driver for droid4 modem Johan Hovold
2020-04-23 15:37   ` Tony Lindgren
2020-04-23 23:27     ` Tony Lindgren
2020-04-25 16:58       ` Tony Lindgren
2020-05-28  8:24     ` Johan Hovold
2020-12-20 22:48       ` Pavel Machek
2020-12-24  8:02         ` Tony Lindgren
2020-12-24 14:59           ` Pavel Machek
2021-01-02 16:23           ` Pavel Machek
2020-04-24 21:50   ` Pavel Machek
2020-04-24 22:15     ` Tony Lindgren
2020-04-26  7:27       ` Pavel Machek
2020-04-26 20:07       ` Pavel Machek
2020-04-26 23:25         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426232520.GP37466@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=jslaby@suse.cz \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=pavel@denx.de \
    --cc=pavel@ucw.cz \
    --cc=peter@hurleysoftware.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCHv6 0/4] n_gsm serdev support and protocol driver for droid4 modem' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).