linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>, <tj@kernel.org>,
	<lizefan@huawei.com>, <cgroups@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <wangkefeng.wang@huawei.com>,
	<linux-mm@kvack.org>, <guro@cmpxchg.org>
Subject: Re: memleak in cgroup
Date: Mon, 27 Apr 2020 10:24:21 -0700	[thread overview]
Message-ID: <20200427172421.GA122591@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20200427171304.GC29022@cmpxchg.org>

On Mon, Apr 27, 2020 at 01:13:04PM -0400, Johannes Weiner wrote:
> +cc Roman who has been looking the most at this area
> 
> On Mon, Apr 27, 2020 at 03:48:13PM +0800, Yang Yingliang wrote:
> > +cc linux-mm@kvack.org <mailto:linux-mm@kvack.org>
> > 
> > On 2020/4/26 19:21, Yang Yingliang wrote:
> > > Hi,
> > > 
> > > When I doing the follow test in kernel-5.7-rc2, I found mem-free is
> > > decreased
> > > 
> > > #!/bin/sh
> > > cd /sys/fs/cgroup/memory/
> > > 
> > > for((i=0;i<45;i++))
> > > do
> > >         for((j=0;j<60000;j++))
> > >         do
> > >                 mkdir /sys/fs/cgroup/memory/yyl-cg$j
> > >         done
> > >         sleep 1
> > >         ls /sys/fs/cgroup/memory/ | grep yyl | xargs rmdir
> > > done
> 
> Should be easy enough to reproduce, thanks for the report. I'll try to
> take a look later this week, unless Roman beats me to it.
> 
> Is this a new observation in 5.7-rc2?
> 
> Can you provide /sys/fs/cgroup/unified/cgroup.stat after the test?

I'm actually trying to reproduce it now, but so far haven't found any issues.

Yang, can you, please, attach the config you're using?

And also confirm that you're giving the system some time before looking
at the memory statistics? Reclaim of internal cgroup structure is a complex
process which might take some time to finish.

Is dmesg also clean?

Thanks!

  reply	other threads:[~2020-04-27 17:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 11:21 memleak in cgroup Yang Yingliang
     [not found] ` <34dfdb52-6efd-7b11-07c8-9461a13b3aa4@huawei.com>
2020-04-27 17:13   ` Johannes Weiner
2020-04-27 17:24     ` Roman Gushchin [this message]
2020-04-28  9:10       ` Yang Yingliang
2020-04-28 17:45         ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427172421.GA122591@carbon.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@cmpxchg.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).