From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Haiwei Li <lihaiwei@tencent.com>
Subject: Re: [PATCH v3 3/5] KVM: VMX: Optimize posted-interrupt delivery for timer fastpath
Date: Mon, 27 Apr 2020 11:37:37 -0700 [thread overview]
Message-ID: <20200427183737.GP14870@linux.intel.com> (raw)
In-Reply-To: <1587709364-19090-4-git-send-email-wanpengli@tencent.com>
On Fri, Apr 24, 2020 at 02:22:42PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Optimizing posted-interrupt delivery especially for the timer fastpath
> scenario, I observe kvm_x86_ops.deliver_posted_interrupt() has more latency
> then vmx_sync_pir_to_irr() in the case of timer fastpath scenario, since
> it needs to wait vmentry, after that it can handle external interrupt, ack
> the notification vector, read posted-interrupt descriptor etc, it is slower
> than evaluate and delivery during vmentry immediately approach. Let's skip
> sending interrupt to notify target pCPU and replace by vmx_sync_pir_to_irr()
> before each cont_run.
>
> Tested-by: Haiwei Li <lihaiwei@tencent.com>
> Cc: Haiwei Li <lihaiwei@tencent.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 9 ++++++---
> virt/kvm/kvm_main.c | 1 +
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 5c21027..d21b66b 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -3909,8 +3909,9 @@ static int vmx_deliver_posted_interrupt(struct kvm_vcpu *vcpu, int vector)
> if (pi_test_and_set_on(&vmx->pi_desc))
> return 0;
>
> - if (!kvm_vcpu_trigger_posted_interrupt(vcpu, false))
> - kvm_vcpu_kick(vcpu);
> + if (vcpu != kvm_get_running_vcpu() &&
> + !kvm_vcpu_trigger_posted_interrupt(vcpu, false))
Bad indentation.
> + kvm_vcpu_kick(vcpu);
>
> return 0;
> }
> @@ -6757,8 +6758,10 @@ static enum exit_fastpath_completion vmx_vcpu_run(struct kvm_vcpu *vcpu)
> if (!kvm_need_cancel_enter_guest(vcpu)) {
> exit_fastpath = vmx_exit_handlers_fastpath(vcpu);
> /* static call is better with retpolines */
> - if (exit_fastpath == EXIT_FASTPATH_CONT_RUN)
> + if (exit_fastpath == EXIT_FASTPATH_CONT_RUN) {
> + vmx_sync_pir_to_irr(vcpu);
> goto cont_run;
> + }
> }
>
> return exit_fastpath;
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index e7436d0..6a289d1 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -4633,6 +4633,7 @@ struct kvm_vcpu *kvm_get_running_vcpu(void)
>
> return vcpu;
> }
> +EXPORT_SYMBOL_GPL(kvm_get_running_vcpu);
>
> /**
> * kvm_get_running_vcpus - get the per-CPU array of currently running vcpus.
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-04-27 18:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 6:22 [PATCH v3 0/5] KVM: VMX: Tscdeadline timer emulation fastpath Wanpeng Li
2020-04-24 6:22 ` [PATCH v3 1/5] KVM: VMX: Introduce generic fastpath handler Wanpeng Li
2020-04-27 18:26 ` Sean Christopherson
2020-04-28 0:47 ` Wanpeng Li
2020-04-24 6:22 ` [PATCH v3 2/5] KVM: X86: Introduce need_cancel_enter_guest helper Wanpeng Li
2020-04-26 2:05 ` Wanpeng Li
2020-04-27 18:36 ` Sean Christopherson
2020-04-28 0:44 ` Wanpeng Li
2020-04-28 1:03 ` Sean Christopherson
2020-04-27 18:30 ` Sean Christopherson
2020-04-28 7:17 ` Wanpeng Li
2020-04-24 6:22 ` [PATCH v3 3/5] KVM: VMX: Optimize posted-interrupt delivery for timer fastpath Wanpeng Li
2020-04-27 18:37 ` Sean Christopherson [this message]
2020-04-24 6:22 ` [PATCH v3 4/5] KVM: X86: TSCDEADLINE MSR emulation fastpath Wanpeng Li
2020-04-27 18:38 ` Sean Christopherson
2020-04-24 6:22 ` [PATCH v3 5/5] KVM: VMX: Handle preemption timer fastpath Wanpeng Li
2020-04-27 18:42 ` Sean Christopherson
2020-04-28 0:45 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427183737.GP14870@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=lihaiwei@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).