From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: andrew.hendry@gmail.com, kuba@kernel.org, allison@lohutok.net,
tglx@linutronix.de, gregkh@linuxfoundation.org,
tanxin.ctf@gmail.com, xiyuyang19@fudan.edu.cn,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/x25: Fix null-ptr-deref in x25_disconnect
Date: Tue, 28 Apr 2020 14:11:11 -0700 (PDT) [thread overview]
Message-ID: <20200428.141111.54288142814578996.davem@davemloft.net> (raw)
In-Reply-To: <20200428081208.26308-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 28 Apr 2020 16:12:08 +0800
> We should check null before do x25_neigh_put in x25_disconnect,
> otherwise may cause null-ptr-deref like this:
...
> Reported-by: syzbot+6db548b615e5aeefdce2@syzkaller.appspotmail.com
> Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
next prev parent reply other threads:[~2020-04-28 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 4:58 net test error: KASAN: null-ptr-deref Write in x25_disconnect syzbot
2020-04-28 8:12 ` [PATCH] net/x25: Fix null-ptr-deref " YueHaibing
2020-04-28 21:11 ` David Miller [this message]
2020-04-28 17:52 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428.141111.54288142814578996.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allison@lohutok.net \
--cc=andrew.hendry@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=tglx@linutronix.de \
--cc=xiyuyang19@fudan.edu.cn \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).