From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: keescook@chromium.org, shuah@kernel.org, netdev@vger.kernel.org,
luto@amacapital.net, wad@chromium.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Tim.Bird@sony.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v6 0/5] kselftest: add fixture parameters
Date: Mon, 27 Apr 2020 18:03:46 -0700 [thread overview]
Message-ID: <20200428010351.331260-1-kuba@kernel.org> (raw)
Hi!
This set is an attempt to make running tests for different
sets of data easier. The direct motivation is the tls
test which we'd like to run for TLS 1.2 and TLS 1.3,
but currently there is no easy way to invoke the same
tests with different parameters.
Tested all users of kselftest_harness.h.
Dave, would it be possible to take these via net-next?
It seems we're failing to get Shuah's attention.
v2:
- don't run tests by fixture
- don't pass params as an explicit argument
v3:
- go back to the orginal implementation with an extra
parameter, and running by fixture (Kees);
- add LIST_APPEND helper (Kees);
- add a dot between fixture and param name (Kees);
- rename the params to variants (Tim);
v4:
- whitespace fixes.
v5 (Kees):
- move a comment;
- remove a temporary variable;
- reword the commit message on patch 4.
v6:
- resend for net-next.
v1: https://lore.kernel.org/netdev/20200313031752.2332565-1-kuba@kernel.org/
v2: https://lore.kernel.org/netdev/20200314005501.2446494-1-kuba@kernel.org/
v3: https://lore.kernel.org/netdev/20200316225647.3129354-1-kuba@kernel.org/
v4: https://lore.kernel.org/netdev/20200317010419.3268916-1-kuba@kernel.org/
v5: https://lore.kernel.org/netdev/20200318010153.40797-1-kuba@kernel.org/
Jakub Kicinski (5):
kselftest: factor out list manipulation to a helper
kselftest: create fixture objects
kselftest: run tests by fixture
kselftest: add fixture variants
selftests: tls: run all tests for TLS 1.2 and TLS 1.3
Documentation/dev-tools/kselftest.rst | 3 +-
tools/testing/selftests/kselftest_harness.h | 234 +++++++++++++++-----
tools/testing/selftests/net/tls.c | 93 ++------
3 files changed, 202 insertions(+), 128 deletions(-)
--
2.25.4
next reply other threads:[~2020-04-28 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 1:03 Jakub Kicinski [this message]
2020-04-28 1:03 ` [PATCH net-next v6 1/5] kselftest: factor out list manipulation to a helper Jakub Kicinski
2020-04-28 1:03 ` [PATCH net-next v6 2/5] kselftest: create fixture objects Jakub Kicinski
2020-04-28 1:03 ` [PATCH net-next v6 3/5] kselftest: run tests by fixture Jakub Kicinski
2020-04-28 1:03 ` [PATCH net-next v6 4/5] kselftest: add fixture variants Jakub Kicinski
2020-04-28 1:03 ` [PATCH net-next v6 5/5] selftests: tls: run all tests for TLS 1.2 and TLS 1.3 Jakub Kicinski
2020-04-28 20:31 ` [PATCH net-next v6 0/5] kselftest: add fixture parameters David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428010351.331260-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=Tim.Bird@sony.com \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).