From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4BFFC83000 for ; Tue, 28 Apr 2020 06:55:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A53A5206B9 for ; Tue, 28 Apr 2020 06:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588056928; bh=ujTtylA/phrBZ8ch8RBwoXgLGoWz0Wx/496DeKxbNQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FN+rHNQ/uqatAWUrI7SzvUtqSm8BwPateF2+wxFKPjrutvVHroWOf+sSMeocRUHXF wDifu3baO5+w6wo91d0afrm7nAG1WCe6vwCjRjhLBPjvcJ/U0ZloFo++n7nOOkwhYy 2Ub71np9ZC73wvgkHxIYjwj5SRgGetCVLdH3LOiA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbgD1Gz1 (ORCPT ); Tue, 28 Apr 2020 02:55:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:54982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgD1Gz1 (ORCPT ); Tue, 28 Apr 2020 02:55:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 717A7206B8; Tue, 28 Apr 2020 06:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588056927; bh=ujTtylA/phrBZ8ch8RBwoXgLGoWz0Wx/496DeKxbNQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l/4fnZb1+F7QykUyFuMsrc0ivfseA8LbsIokFGWuuzpv3bTYI5bO4iyzxWYPOInyo mWEEwULk0N1YXlS0jxzzAK2xsq0CFq/CHpD3HITKqthF69dtXCg8tnrlG3Rdn4WjMF Eh4AjMGZyxSlGlmJtNGBzebcNG69mmPgsG46iGCs= Date: Tue, 28 Apr 2020 08:55:24 +0200 From: Greg KH To: Vinod Koul Cc: Bard Liao , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, jank@cadence.com, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, slawomir.blauciak@intel.com, mengdong.lin@intel.com Subject: Re: [RFC 1/5] soundwire: bus_type: add sdw_master_device support Message-ID: <20200428065524.GA992087@kroah.com> References: <20200416205524.2043-1-yung-chuan.liao@linux.intel.com> <20200416205524.2043-2-yung-chuan.liao@linux.intel.com> <20200420072631.GW72691@vkoul-mobl> <20200423142451.GA4181720@kroah.com> <20200428043144.GU56386@vkoul-mobl.Dlink> <20200428063736.GB990431@kroah.com> <20200428064951.GA56386@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428064951.GA56386@vkoul-mobl.Dlink> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 12:19:51PM +0530, Vinod Koul wrote: > On 28-04-20, 08:37, Greg KH wrote: > > On Tue, Apr 28, 2020 at 10:01:44AM +0530, Vinod Koul wrote: > > > > > That is not true for everyone, it is only true for Intel, pls call that > > > > > out as well... > > > > > > > > Why is it not true for everyone? How else do you get the pm stuff back > > > > to your hardware? > > > > > > The rest of the world would do using the real controller device. For > > > example the soundwire controller on Qualcomm devices is enumerated as a > > > DT device and is using these... > > > > > > If Intel had a standalone controller or enumerated as individual > > > functions, it would have been a PCI device and would manage as such > > > > If it is not a standalone controller, what exactly is it? I thought it > > was an acpi device, am I mistaken? > > > > What is the device that the proper soundwire controller driver binds to > > on an Intel-based system? > > The HDA controller which is a PCI device. The device represent HDA > function, DSP and Soundwire controller instances (yes it is typically > more than one instance) Then those "instances" should be split up into individual devices that a driver can bind to. See the work happening on the "virtual" bus for examples of how that can be done. A platform device better not be being used here, I'm afraid to look at the code now... greg k-h