From: Lee Jones <lee.jones@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Milo Kim <milo.kim@ti.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure
Date: Tue, 28 Apr 2020 08:09:53 +0100 [thread overview]
Message-ID: <20200428070953.GI3559@dell> (raw)
In-Reply-To: <20200224140748.2182-1-jonathanh@nvidia.com>
On Mon, 24 Feb 2020, Jon Hunter wrote:
> If probing the LP885x backlight fails after the regulators have been
> enabled, then the following warning is seen when releasing the
> regulators ...
>
> WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator_put.part.28+0x158/0x160
> Modules linked in: tegra_xudc lp855x_bl(+) host1x pwm_tegra ip_tables x_tables ipv6 nf_defrag_ipv6
> CPU: 1 PID: 289 Comm: systemd-udevd Not tainted 5.6.0-rc2-next-20200224 #1
> Hardware name: NVIDIA Jetson TX1 Developer Kit (DT)
>
> ...
>
> Call trace:
> _regulator_put.part.28+0x158/0x160
> regulator_put+0x34/0x50
> devm_regulator_release+0x10/0x18
> release_nodes+0x12c/0x230
> devres_release_all+0x34/0x50
> really_probe+0x1c0/0x370
> driver_probe_device+0x58/0x100
> device_driver_attach+0x6c/0x78
> __driver_attach+0xb0/0xf0
> bus_for_each_dev+0x68/0xc8
> driver_attach+0x20/0x28
> bus_add_driver+0x160/0x1f0
> driver_register+0x60/0x110
> i2c_register_driver+0x40/0x80
> lp855x_driver_init+0x20/0x1000 [lp855x_bl]
> do_one_initcall+0x58/0x1a0
> do_init_module+0x54/0x1d0
> load_module+0x1d80/0x21c8
> __do_sys_finit_module+0xe8/0x100
> __arm64_sys_finit_module+0x18/0x20
> el0_svc_common.constprop.3+0xb0/0x168
> do_el0_svc+0x20/0x98
> el0_sync_handler+0xf4/0x1b0
> el0_sync+0x140/0x180
>
> Fix this by ensuring that the regulators are disabled, if enabled, on
> probe failure.
>
> Finally, ensure that the vddio regulator is disabled in the driver
> remove handler.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-04-28 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:07 [PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure Jon Hunter
2020-02-24 14:37 ` Daniel Thompson
2020-03-13 14:16 ` Jon Hunter
2020-03-16 9:05 ` Daniel Thompson
2020-04-27 13:17 ` Jon Hunter
2020-04-28 7:09 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428070953.GI3559@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=milo.kim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).