From: Lee Jones <lee.jones@linaro.org>
To: Baolin Wang <baolin.wang7@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mfd: syscon: Add Spreadtrum physical regmap bus support
Date: Tue, 28 Apr 2020 08:14:47 +0100 [thread overview]
Message-ID: <20200428071447.GJ3559@dell> (raw)
In-Reply-To: <CADBw62qXtNnoNq0F1iZrvQHryMTy86GEqcD-qXBzsJJL-B8mQg@mail.gmail.com>
On Tue, 28 Apr 2020, Baolin Wang wrote:
> On Mon, Apr 27, 2020 at 5:05 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Mon, 27 Apr 2020, Baolin Wang wrote:
> >
> > > Hi Arnd and Lee,
> > >
> > > On Tue, Apr 21, 2020 at 10:13 PM Baolin Wang <baolin.wang7@gmail.com> wrote:
> > > >
> > > > Some platforms such as Spreadtrum platform, define a special method to
> > > > update bits of the registers instead of read-modify-write, which means
> > > > we should use a physical regmap bus to define the reg_update_bits()
> > > > operation instead of the MMIO regmap bus. Thus we can register a new
> > > > physical regmap bus into syscon core to support this.
> > > >
> > > > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> > >
> > > Do you have any comments for this patch? Thanks.
> >
> > Yes. I'm not accepting it, sorry.
> >
> > I'd rather you duplicate the things you need from of_syscon_register()
> > in your own driver than taint this one.
>
> Thanks for your comments and I can understand your concern. But we
> still want to use the standard syscon APIs in syscon.c, which means we
> still need insert an callback or registration or other similar methods
> to support vendor specific regmap bus. Otherwise we should invent some
> similar syscon APIs in our vendor syscon driver, like
> sprd_syscon_regmap_lookup_by_phandle/sprd_syscon_regmap_lookup_by_compatible.
So long as the generic driver stays generic. Providing a registration
function sounds cleaner than tainting the code with vendor specifics.
> Arnd, what do you think? Thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-28 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 14:13 [PATCH v3] mfd: syscon: Add Spreadtrum physical regmap bus support Baolin Wang
2020-04-27 7:23 ` Baolin Wang
2020-04-27 9:05 ` Lee Jones
2020-04-28 7:06 ` Baolin Wang
2020-04-28 7:14 ` Lee Jones [this message]
2020-04-28 8:09 ` Baolin Wang
2020-04-28 8:19 ` Lee Jones
2020-04-28 8:41 ` Baolin Wang
2020-05-04 8:21 ` Baolin Wang
2020-05-19 10:35 ` Lee Jones
2020-05-19 13:10 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428071447.GJ3559@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).