Hi Stefan,

On Sat, Apr 25, 2020 at 10:54:22PM +0200, Stefan Wahren wrote:
> Hi Maxime,
> 
> Am 24.04.20 um 17:35 schrieb Maxime Ripard:
> > Now that all the drivers have been adjusted for it, let's bring in the
> > necessary device tree changes.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> >  arch/arm/boot/dts/bcm2711-rpi-4-b.dts |  46 +++++++++++-
> >  arch/arm/boot/dts/bcm2711.dtsi        | 115 ++++++++++++++++++++++++++-
> >  2 files changed, 160 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> > index 3205d2dfa898..0efbc4412dc9 100644
> > --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> > +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> > @@ -220,3 +220,49 @@
> >  &vchiq {
> >  	interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
> >  };
> > +
> > +&vc4 {
> > +	status = "okay";
> > +};
> > +
> > +&pixelvalve0 {
> > +	status = "okay";
> > +};
> > +
> > +&pixelvalve1 {
> > +	status = "okay";
> > +};
> > +
> > +&pixelvalve2 {
> > +	status = "okay";
> > +};
> > +
> > +&pixelvalve3 {
> > +	status = "okay";
> > +};
> > +
> > +&pixelvalve4 {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi0 {
> > +	clocks = <&firmware_clocks 13>, <&dvp 0>;
> > +	status = "okay";
> > +};
> > +
> > +&ddc0 {
> > +	status = "okay";
> > +};
> > +
> > +&hdmi1 {
> > +	clocks = <&firmware_clocks 13>, <&dvp 1>;
> > +	status = "okay";
> > +};
> > +
> > +&ddc1 {
> > +	status = "okay";
> > +};
> > +
> > +&hvs {
> > +	clocks = <&firmware_clocks 4>;
> > +};
> > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> > index 00bcaed1be32..a6549fa6e62b 100644
> > --- a/arch/arm/boot/dts/bcm2711.dtsi
> > +++ b/arch/arm/boot/dts/bcm2711.dtsi
> > @@ -12,6 +12,11 @@
> >  
> >  	interrupt-parent = <&gicv2>;
> >  
> ...
> > +
> > +		ddc0: i2c@7ef04500 {
> > +			compatible = "brcm,bcm2711-hdmi-i2c";
> > +			reg = <0x7ef04500 0x100>, <0x7ef00b00 0x300>;
> > +			reg-names = "bsc", "auto-i2c";
> > +			clock-frequency = <390000>;
> 
> according to a patch [1] from Dave Stevenson the i2c clock frequencies
> are too high.
> 
> [1] -
> https://github.com/raspberrypi/linux/pull/3515/commits/c09f108de27e8bd1995e7713c6128fa79e69579a

Good catch, I'll merge it in my next round of changes

Maxime