From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4807C83000 for ; Tue, 28 Apr 2020 17:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64E482085B for ; Tue, 28 Apr 2020 17:29:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YixUwvPk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728550AbgD1R3r (ORCPT ); Tue, 28 Apr 2020 13:29:47 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22812 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728540AbgD1R3q (ORCPT ); Tue, 28 Apr 2020 13:29:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588094985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgJQcSK6eEoH1/P5II7XvVifG0Bg4C73XG6IT0CFhZk=; b=YixUwvPkuViqLrCheTzEISsqz7m6nF+fFdO6ZAKJ9cC07rjJBrn77fo445dAk/wgvVAGm0 hkYTQ4C73LDdVQ5fH0OBdHxvV5QPXdFsvE1xbAUpvcdpqHDA6PhidM2Q9tww3NuE0cAol/ JDpB2Qh9olEYsqXD/OKCjYkEx3lfaJM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-RkifAn5GP4WdiMVbXceFig-1; Tue, 28 Apr 2020 13:29:41 -0400 X-MC-Unique: RkifAn5GP4WdiMVbXceFig-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB326835B41; Tue, 28 Apr 2020 17:29:39 +0000 (UTC) Received: from x1.localdomain.com (ovpn-114-62.ams2.redhat.com [10.36.114.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5087F5C1D4; Tue, 28 Apr 2020 17:29:37 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" , Len Brown , Darren Hart , Andy Shevchenko , Jonathan Cameron Cc: Hans de Goede , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Andy Shevchenko Subject: [PATCH v3 04/11] iio: light: cm32181: Add support for the CM3218 Date: Tue, 28 Apr 2020 19:29:16 +0200 Message-Id: <20200428172923.567806-4-hdegoede@redhat.com> In-Reply-To: <20200428172923.567806-1-hdegoede@redhat.com> References: <20200428172923.567806-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for the CM3218 which is an older version of the CM32181. This is based on a newer version of cm32181.c, with a copyright of: * Copyright (C) 2014 Capella Microsystems Inc. * Author: Kevin Tsai * * This program is free software; you can redistribute it and/or modify i= t * under the terms of the GNU General Public License version 2, as publis= hed * by the Free Software Foundation. Which is floating around on the net in various places, but the changes from this newer version never made it upstream. This was tested on an Asus T100TA and an Asus T100CHI, which both come with the CM3218 variant of the light sensor. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- drivers/iio/light/cm32181.c | 48 +++++++++++++++++++++++++++---------- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c index 6fc0a753c499..065bc7a11f84 100644 --- a/drivers/iio/light/cm32181.c +++ b/drivers/iio/light/cm32181.c @@ -55,15 +55,24 @@ static const u8 cm32181_reg[CM32181_CONF_REG_NUM] =3D= { CM32181_REG_ADDR_CMD, }; =20 -static const int als_it_bits[] =3D {12, 8, 0, 1, 2, 3}; -static const int als_it_value[] =3D {25000, 50000, 100000, 200000, 40000= 0, - 800000}; +/* CM3218 Family */ +static const int cm3218_als_it_bits[] =3D { 0, 1, 2, 3 }; +static const int cm3218_als_it_values[] =3D { 100000, 200000, 400000, 80= 0000 }; + +/* CM32181 Family */ +static const int cm32181_als_it_bits[] =3D { 12, 8, 0, 1, 2, 3 }; +static const int cm32181_als_it_values[] =3D { + 25000, 50000, 100000, 200000, 400000, 800000 +}; =20 struct cm32181_chip { struct i2c_client *client; struct mutex lock; u16 conf_regs[CM32181_CONF_REG_NUM]; int calibscale; + int num_als_it; + const int *als_it_bits; + const int *als_it_values; }; =20 /** @@ -85,8 +94,21 @@ static int cm32181_reg_init(struct cm32181_chip *cm321= 81) return ret; =20 /* check device ID */ - if ((ret & 0xFF) !=3D 0x81) + switch (ret & 0xFF) { + case 0x18: /* CM3218 */ + cm32181->num_als_it =3D ARRAY_SIZE(cm3218_als_it_bits); + cm32181->als_it_bits =3D cm3218_als_it_bits; + cm32181->als_it_values =3D cm3218_als_it_values; + break; + case 0x81: /* CM32181 */ + case 0x82: /* CM32182, fully compat. with CM32181 */ + cm32181->num_als_it =3D ARRAY_SIZE(cm32181_als_it_bits); + cm32181->als_it_bits =3D cm32181_als_it_bits; + cm32181->als_it_values =3D cm32181_als_it_values; + break; + default: return -ENODEV; + } =20 /* Default Values */ cm32181->conf_regs[CM32181_REG_ADDR_CMD] =3D @@ -121,9 +143,9 @@ static int cm32181_read_als_it(struct cm32181_chip *c= m32181, int *val2) als_it =3D cm32181->conf_regs[CM32181_REG_ADDR_CMD]; als_it &=3D CM32181_CMD_ALS_IT_MASK; als_it >>=3D CM32181_CMD_ALS_IT_SHIFT; - for (i =3D 0; i < ARRAY_SIZE(als_it_bits); i++) { - if (als_it =3D=3D als_it_bits[i]) { - *val2 =3D als_it_value[i]; + for (i =3D 0; i < cm32181->num_als_it; i++) { + if (als_it =3D=3D cm32181->als_it_bits[i]) { + *val2 =3D cm32181->als_it_values[i]; return IIO_VAL_INT_PLUS_MICRO; } } @@ -146,14 +168,14 @@ static int cm32181_write_als_it(struct cm32181_chip= *cm32181, int val) u16 als_it; int ret, i, n; =20 - n =3D ARRAY_SIZE(als_it_value); + n =3D cm32181->num_als_it; for (i =3D 0; i < n; i++) - if (val <=3D als_it_value[i]) + if (val <=3D cm32181->als_it_values[i]) break; if (i >=3D n) i =3D n - 1; =20 - als_it =3D als_it_bits[i]; + als_it =3D cm32181->als_it_bits[i]; als_it <<=3D CM32181_CMD_ALS_IT_SHIFT; =20 mutex_lock(&cm32181->lock); @@ -265,11 +287,12 @@ static int cm32181_write_raw(struct iio_dev *indio_= dev, static ssize_t cm32181_get_it_available(struct device *dev, struct device_attribute *attr, char *buf) { + struct cm32181_chip *cm32181 =3D iio_priv(dev_to_iio_dev(dev)); int i, n, len; =20 - n =3D ARRAY_SIZE(als_it_value); + n =3D cm32181->num_als_it; for (i =3D 0, len =3D 0; i < n; i++) - len +=3D sprintf(buf + len, "0.%06u ", als_it_value[i]); + len +=3D sprintf(buf + len, "0.%06u ", cm32181->als_it_values[i]); return len + sprintf(buf + len, "\n"); } =20 @@ -345,6 +368,7 @@ static int cm32181_probe(struct i2c_client *client) } =20 static const struct of_device_id cm32181_of_match[] =3D { + { .compatible =3D "capella,cm3218" }, { .compatible =3D "capella,cm32181" }, { } }; --=20 2.26.0