Re: [PATCH v2 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu

From: kbuild test robot <lkp@intel.com>
To: Prasad Sodagudi <psodagud@codeaurora.org>,
	tglx@linutronix.de, john.stultz@linaro.org, sboyd@kernel.org,
	tj@kernel.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	saravanak@google.com, psodagud@codeaurora.org,
	pkondeti@codeaurora.org, Joonwoo Park <joonwoop@codeaurora.org>
Subject: Re: [PATCH v2 1/2] timer: make deferrable cpu unbound timers really not bound to a cpu
Date: Wed, 29 Apr 2020 07:44:42 +0800	[thread overview]
Message-ID: <202004290721.QmYKQWvM%lkp@intel.com> (raw)
In-Reply-To: <1588104579-8712-2-git-send-email-psodagud@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2519 bytes --]

Hi Prasad,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/timers/core]
[also build test ERROR on tip/auto-latest tip/timers/nohz v5.7-rc3 next-20200428]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Prasad-Sodagudi/timer-make-deferrable-cpu-unbound-timers-really-not-bound-to-a-cpu/20200429-060558
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4479730e9263befbb9ce9563a09563db2acb8f7c
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/time/timer.c: In function 'run_timer_softirq':
>> kernel/time/timer.c:1804:18: error: 'timer_base_deferrable' undeclared (first use in this function); did you mean 'timer_base_lock_expiry'?
       __run_timers(&timer_base_deferrable);
                     ^~~~~~~~~~~~~~~~~~~~~
                     timer_base_lock_expiry
   kernel/time/timer.c:1804:18: note: each undeclared identifier is reported only once for each function it appears in
   kernel/time/timer.c: In function 'init_timer_deferrable_global':
   kernel/time/timer.c:2046:2: error: 'timer_base_deferrable' undeclared (first use in this function); did you mean 'timer_base_lock_expiry'?
     timer_base_deferrable.cpu = nr_cpu_ids;
     ^~~~~~~~~~~~~~~~~~~~~
     timer_base_lock_expiry

vim +1804 kernel/time/timer.c

  1791	
  1792	/*
  1793	 * This function runs timers and the timer-tq in bottom half context.
  1794	 */
  1795	static __latent_entropy void run_timer_softirq(struct softirq_action *h)
  1796	{
  1797		struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_STD]);
  1798	
  1799		__run_timers(base);
  1800		if (IS_ENABLED(CONFIG_NO_HZ_COMMON)) {
  1801			__run_timers(this_cpu_ptr(&timer_bases[BASE_DEF]));
  1802			if (tick_do_timer_cpu == TICK_DO_TIMER_NONE ||
  1803					tick_do_timer_cpu == smp_processor_id())
> 1804				__run_timers(&timer_base_deferrable);
  1805		}
  1806	}
  1807	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7238 bytes --]