From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57569C83007 for ; Wed, 29 Apr 2020 10:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FDE82073E for ; Wed, 29 Apr 2020 10:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbgD2KRn (ORCPT ); Wed, 29 Apr 2020 06:17:43 -0400 Received: from mga05.intel.com ([192.55.52.43]:30681 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726621AbgD2KRm (ORCPT ); Wed, 29 Apr 2020 06:17:42 -0400 IronPort-SDR: 3IM+E+WeE7+4VkJwoxzrB9BZH/FghVldTZDBMh/hAJ66IYSWnFsXUT1fAw5/Uv2964DspL7cIm MEQgNmVnTo1w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 03:17:41 -0700 IronPort-SDR: eE+O1+6e1XtGtd8JUdDlakeYwWPFk4LNtvwubLqQnCneIupXarg2zWhgxwP/6zJHH+XbmHkf8n cqRnVG+imodg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,331,1583222400"; d="scan'208";a="276127910" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 29 Apr 2020 03:17:39 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jTjmg-003huG-1Q; Wed, 29 Apr 2020 13:17:42 +0300 Date: Wed, 29 Apr 2020 13:17:42 +0300 From: Andy Shevchenko To: Syed Nayyar Waris Cc: akpm@linux-foundation.org, vilhelm.gray@gmail.com, rrichter@marvell.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set_clump macro Message-ID: <20200429101742.GE185537@smile.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 04:37:41AM +0530, Syed Nayyar Waris wrote: > This patch reimplements the thunderx_gpio_set_multiple function in > drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro. > Instead of looping for each bank in thunderx_gpio_set_multiple > function, now we can skip bank which is not set and save cycles. > + const unsigned long bank_size = 64; Shouldn't be rather definition? -- With Best Regards, Andy Shevchenko