* [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64
@ 2020-04-28 16:41 Peter Vasil
2020-04-29 12:03 ` Maxime Ripard
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Vasil @ 2020-04-28 16:41 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Maxime Ripard,
Chen-Yu Tsai, linux-pwm, linux-arm-kernel, linux-kernel
Cc: peter.vasil, nightwolf
Allwinner A64 is capable of a direct clock output on PWM (see A64
User Manual chapter 3.10). Add support for this in the sun4i PWM
driver.
Signed-off-by: Peter Vasil <peter.vasil@gmail.com>
---
drivers/pwm/pwm-sun4i.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 5c677c563349..18fbbe3277d0 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -352,6 +352,12 @@ static const struct sun4i_pwm_data sun4i_pwm_single_bypass = {
.npwm = 1,
};
+static const struct sun4i_pwm_data sun50i_a64_pwm_data = {
+ .has_prescaler_bypass = true,
+ .has_direct_mod_clk_output = true,
+ .npwm = 1,
+};
+
static const struct sun4i_pwm_data sun50i_h6_pwm_data = {
.has_prescaler_bypass = true,
.has_direct_mod_clk_output = true,
@@ -374,6 +380,9 @@ static const struct of_device_id sun4i_pwm_dt_ids[] = {
}, {
.compatible = "allwinner,sun8i-h3-pwm",
.data = &sun4i_pwm_single_bypass,
+ }, {
+ .compatible = "allwinner,sun50i-a64-pwm",
+ .data = &sun50i_a64_pwm_data,
}, {
.compatible = "allwinner,sun50i-h6-pwm",
.data = &sun50i_h6_pwm_data,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64
2020-04-28 16:41 [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64 Peter Vasil
@ 2020-04-29 12:03 ` Maxime Ripard
2020-04-29 13:43 ` Uwe Kleine-König
2020-06-02 12:40 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2020-04-29 12:03 UTC (permalink / raw)
To: Peter Vasil
Cc: Thierry Reding, Uwe Kleine-König, Chen-Yu Tsai, linux-pwm,
linux-arm-kernel, linux-kernel, nightwolf
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Tue, Apr 28, 2020 at 06:41:50PM +0200, Peter Vasil wrote:
> Allwinner A64 is capable of a direct clock output on PWM (see A64
> User Manual chapter 3.10). Add support for this in the sun4i PWM
> driver.
>
> Signed-off-by: Peter Vasil <peter.vasil@gmail.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64
2020-04-28 16:41 [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64 Peter Vasil
2020-04-29 12:03 ` Maxime Ripard
@ 2020-04-29 13:43 ` Uwe Kleine-König
2020-06-02 12:40 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2020-04-29 13:43 UTC (permalink / raw)
To: Peter Vasil
Cc: Thierry Reding, Maxime Ripard, Chen-Yu Tsai, linux-pwm,
linux-arm-kernel, linux-kernel, nightwolf
On Tue, Apr 28, 2020 at 06:41:50PM +0200, Peter Vasil wrote:
> Allwinner A64 is capable of a direct clock output on PWM (see A64
> User Manual chapter 3.10). Add support for this in the sun4i PWM
> driver.
>
> Signed-off-by: Peter Vasil <peter.vasil@gmail.com>
LGTM
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64
2020-04-28 16:41 [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64 Peter Vasil
2020-04-29 12:03 ` Maxime Ripard
2020-04-29 13:43 ` Uwe Kleine-König
@ 2020-06-02 12:40 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2020-06-02 12:40 UTC (permalink / raw)
To: Peter Vasil
Cc: Uwe Kleine-König, Maxime Ripard, Chen-Yu Tsai, linux-pwm,
linux-arm-kernel, linux-kernel, nightwolf
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On Tue, Apr 28, 2020 at 06:41:50PM +0200, Peter Vasil wrote:
> Allwinner A64 is capable of a direct clock output on PWM (see A64
> User Manual chapter 3.10). Add support for this in the sun4i PWM
> driver.
>
> Signed-off-by: Peter Vasil <peter.vasil@gmail.com>
> ---
> drivers/pwm/pwm-sun4i.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-02 12:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 16:41 [PATCH v2] pwm: sun4i: direct clock output support for Allwinner A64 Peter Vasil
2020-04-29 12:03 ` Maxime Ripard
2020-04-29 13:43 ` Uwe Kleine-König
2020-06-02 12:40 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).