From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: kajoljain <kjain@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
sukadev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, anju@linux.vnet.ibm.com,
maddy@linux.vnet.ibm.com, ravi.bangoria@linux.ibm.com,
peterz@infradead.org, yao.jin@linux.intel.com,
ak@linux.intel.com, jolsa@kernel.org, kan.liang@linux.intel.com,
jmario@redhat.com, alexander.shishkin@linux.intel.com,
mingo@kernel.org, paulus@ozlabs.org, namhyung@kernel.org,
mpetlan@redhat.com, gregkh@linuxfoundation.org,
benh@kernel.crashing.org, mamatha4@linux.vnet.ibm.com,
mark.rutland@arm.com, tglx@linutronix.de
Subject: Re: [PATCH v8 0/7] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events
Date: Wed, 29 Apr 2020 11:46:46 -0300 [thread overview]
Message-ID: <20200429144646.GA30487@kernel.org> (raw)
In-Reply-To: <fa31bc42-d34c-c788-0109-350d769b51ce@linux.ibm.com>
Em Tue, Apr 28, 2020 at 12:02:42PM +0530, kajoljain escreveu:
> Hi Arnaldo,
> Please let me know if there any changes required in this patchset,
> as some of its patches are still not part of your perf/core tree.
Thanks, I checked and all seems ok, added Jiri's Acked-by, appreciated,
thanks,
- Arnaldo
> Thanks,
> Kajol Jain
>
> On 4/2/20 2:03 AM, Kajol Jain wrote:
> > Patchset adds json file metric support for the hv_24x7 socket/chip level
> > events. "hv_24x7" pmu interface events needs system dependent parameter
> > like socket/chip/core. For example, hv_24x7 chip level events needs
> > specific chip-id to which the data is requested should be added as part
> > of pmu events.
> >
> > So to enable JSON file support to "hv_24x7" interface, patchset reads
> > total number of sockets details in sysfs under
> > "/sys/devices/hv_24x7/interface/".
> >
> > Second patch of the patchset adds expr_scanner_ctx object to hold user
> > data for the expr scanner, which can be used to hold runtime parameter.
> >
> > Patch 4 & 6 of the patchset handles perf tool plumbing needed to replace
> > the "?" character in the metric expression to proper value and hv_24x7
> > json metric file for different Socket/chip resources.
> >
> > Patch set also enable Hz/hz prinitg for --metric-only option to print
> > metric data for bus frequency.
> >
> > Applied and tested all these patches cleanly on top of jiri's flex changes
> > with the changes done by Kan Liang for "Support metric group constraint"
> > patchset and made required changes.
> >
> > Also apply this patch on top of the fix patch send earlier
> > for printing metric name incase overlapping events.
> > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=37cd7f65bf71a48f25eeb6d9be5dacb20d008ea6
> >
> > Changelog:
> > v7 -> v8
> > - Add test case for testing parsing of "?" in metric expression
> > - Reaname variables name to runtime
> >
> > v6 -> v7
> > - Spit patchset into two patch series one for kernel changes and other
> > for tool side changes.
> > - Made changes Suggested by Jiri, including rather then reading runtime
> > parameter from metric name, actually add it in structure egroup and
> > metric_expr.
> > - As we don't need to read runtime parameter from metric name,
> > now I am not appending it and rather just printing it in
> > generic_metric function.
> >
> > Kernel Side changes patch series: https://lkml.org/lkml/2020/3/27/58
> >
> > v5 -> v6
> > - resolve compilation issue due to rearranging patch series.
> > - Rather then adding new function to take careof case for runtime param
> > in metricgroup__add_metric, using metricgroup__add_metric_param itself
> > for that work.
> > - Address some optimization suggested like using directly file path
> > rather then adding new macro in header.c
> > - Change commit message on patch where we are adding "?" support
> > by adding simple example.
> >
> > v4 -> v5
> > - Using sysfs__read_int instead of sysfs__read_ull while reading
> > parameter value in powerpc/util/header.c file.
> >
> > - Using asprintf rather then malloc and sprintf
> > Suggested by Arnaldo Carvalho de Melo
> >
> > - Break patch 6 from previous version to two patch,
> > - One to add refactor current "metricgroup__add_metric" function
> > and another where actually "?" handling infra added.
> >
> > - Add expr__runtimeparam as part of 'expr_scanner_ctx' struct
> > rather then making it global variable. Thanks Jiri for
> > adding this structure to hold user data for the expr scanner.
> >
> > - Add runtime param as agrugement to function 'expr__find_other'
> > and 'expr__parse' and made changes on references accordingly.
> >
> > v3 -> v4
> > - Apply these patch on top of Kan liang changes.
> > As suggested by Jiri.
> >
> > v2 -> v3
> > - Remove setting event_count to 0 part in function 'h_24x7_event_read'
> > with comment rather then adding 0 to event_count value.
> > Suggested by: Sukadev Bhattiprolu
> >
> > - Apply tool side changes require to replace "?" on Jiri's flex patch
> > series and made all require changes to make it compatible with added
> > flex change.
> >
> > v1 -> v2
> > - Rename hv-24x7 metric json file as nest_metrics.json
> >
> > Jiri Olsa (2):
> > perf expr: Add expr_ prefix for parse_ctx and parse_id
> > perf expr: Add expr_scanner_ctx object
> >
> > Kajol Jain (5):
> > perf/tools: Refactoring metricgroup__add_metric function
> > perf/tools: Enhance JSON/metric infrastructure to handle "?"
> > perf/tests/expr: Added test for runtime param in metric expression
> > tools/perf: Enable Hz/hz prinitg for --metric-only option
> > perf/tools/pmu-events/powerpc: Add hv_24x7 socket/chip level metric
> > events
> >
> > tools/perf/arch/powerpc/util/header.c | 8 ++
> > .../arch/powerpc/power9/nest_metrics.json | 19 +++++
> > tools/perf/tests/expr.c | 20 +++--
> > tools/perf/util/expr.c | 25 +++---
> > tools/perf/util/expr.h | 19 +++--
> > tools/perf/util/expr.l | 37 ++++++---
> > tools/perf/util/expr.y | 6 +-
> > tools/perf/util/metricgroup.c | 78 +++++++++++++------
> > tools/perf/util/metricgroup.h | 2 +
> > tools/perf/util/stat-display.c | 2 -
> > tools/perf/util/stat-shadow.c | 19 +++--
> > 11 files changed, 164 insertions(+), 71 deletions(-)
> > create mode 100644 tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json
> >
--
- Arnaldo
prev parent reply other threads:[~2020-04-29 14:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 20:33 [PATCH v8 0/7] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events Kajol Jain
2020-04-01 20:33 ` [PATCH v8 1/7] perf expr: Add expr_ prefix for parse_ctx and parse_id Kajol Jain
2020-04-06 14:13 ` Arnaldo Carvalho de Melo
2020-04-07 7:11 ` kajoljain
2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2020-04-01 20:33 ` [PATCH v8 2/7] perf expr: Add expr_scanner_ctx object Kajol Jain
2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2020-04-01 20:33 ` [PATCH v8 3/7] perf/tools: Refactoring metricgroup__add_metric function Kajol Jain
2020-04-22 12:17 ` [tip: perf/core] perf metrictroup: Split the " tip-bot2 for Kajol Jain
2020-04-01 20:33 ` [PATCH v8 4/7] perf/tools: Enhance JSON/metric infrastructure to handle "?" Kajol Jain
2020-05-01 15:56 ` Ian Rogers
2020-05-08 13:05 ` [tip: perf/core] perf metricgroups: " tip-bot2 for Kajol Jain
2020-04-01 20:33 ` [PATCH v8 5/7] perf/tests/expr: Added test for runtime param in metric expression Kajol Jain
2020-05-08 13:05 ` [tip: perf/core] perf tests expr: " tip-bot2 for Kajol Jain
2020-04-01 20:33 ` [PATCH v8 6/7] tools/perf: Enable Hz/hz prinitg for --metric-only option Kajol Jain
2020-04-02 12:49 ` Jiri Olsa
2020-04-02 20:42 ` Andi Kleen
2020-05-08 13:05 ` [tip: perf/core] perf tools: " tip-bot2 for Kajol Jain
2020-04-01 20:33 ` [PATCH v8 7/7] perf/tools/pmu-events/powerpc: Add hv_24x7 socket/chip level metric events Kajol Jain
2020-05-08 13:05 ` [tip: perf/core] perf vendor events power9: " tip-bot2 for Kajol Jain
2020-04-02 21:27 ` [PATCH v8 0/7] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events Jiri Olsa
2020-04-28 6:32 ` kajoljain
2020-04-29 14:46 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429144646.GA30487@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mamatha4@linux.vnet.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@ozlabs.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).