From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D999DC83000 for ; Wed, 29 Apr 2020 15:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3C76206B8 for ; Wed, 29 Apr 2020 15:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727073AbgD2PlE (ORCPT ); Wed, 29 Apr 2020 11:41:04 -0400 Received: from foss.arm.com ([217.140.110.172]:41282 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbgD2PlD (ORCPT ); Wed, 29 Apr 2020 11:41:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82FFF1045; Wed, 29 Apr 2020 08:41:02 -0700 (PDT) Received: from e107158-lin (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3649F3F68F; Wed, 29 Apr 2020 08:41:00 -0700 (PDT) Date: Wed, 29 Apr 2020 16:40:57 +0100 From: Qais Yousef To: Pavan Kondeti Cc: Peter Zijlstra , Ingo Molnar , Jonathan Corbet , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Luis Chamberlain , Kees Cook , Iurii Zaikin , Quentin Perret , Valentin Schneider , Patrick Bellasi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 1/2] sched/uclamp: Add a new sysctl to control RT default boost value Message-ID: <20200429154056.bznhs6wc2iyxzevy@e107158-lin> References: <20200428164134.5588-1-qais.yousef@arm.com> <20200429113255.GA19464@codeaurora.org> <20200429123056.otyedhljlugyf5we@e107158-lin> <20200429152106.GB19464@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200429152106.GB19464@codeaurora.org> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/29/20 20:51, Pavan Kondeti wrote: > As we are copying the sysctl_sched_uclamp_util_min_rt_default value into > p->uclamp_req[UCLAMP_MIN], user gets it when sched_getattr() is called though > sched_setattr() was not called before. I guess that is expected behavior with > your definition of this new tunable. Thanks for answering the question in > detail. Yes. That's the original design without this patch actually. Though before it was always set to 1024. Thanks for having a look! -- Qais Yousef