From: Rob Herring <robh@kernel.org>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Min Guo <min.Guo@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
Macpaul Lin <macpaul.lin@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: phy-mtk-tphy: add the property about force_vbus
Date: Wed, 29 Apr 2020 16:30:34 -0500 [thread overview]
Message-ID: <20200429213034.GA29572@bogus> (raw)
In-Reply-To: <1587100986-3104-1-git-send-email-macpaul.lin@mediatek.com>
On Fri, Apr 17, 2020 at 01:23:05PM +0800, Macpaul Lin wrote:
> For some platforms, they don't have vbus pin connection between usb's phy
> and mac. Hence we need to control force_vbus related registers to keep
> hardware works normal.
> This patch add the required bool property force_vbus.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> index dd75b676b71d..6b49b651becc 100644
> --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> @@ -37,6 +37,9 @@ Optional properties (controller (parent) node):
> calibrate
> - mediatek,src-coef : coefficient for slew rate calibrate, depends on
> SoC process
> + - force_vbus : if the platform has no vbus connection between phy and mac,
mediatek,force-vbus
This is board specific? If SoC specific, you should drop and imply this
from the compatible string.
> + (force_vbus mode), then this property should be exist.
> + Otherwise not to add this property.
>
> Required properties (port (child) node):
> - reg : address and length of the register set for the port.
> --
> 2.18.0
prev parent reply other threads:[~2020-04-29 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 5:23 [PATCH 1/2] dt-bindings: phy-mtk-tphy: add the property about force_vbus Macpaul Lin
2020-04-17 5:23 ` [PATCH 2/2] phy: phy-mtk-tphy: introduce force_vbus for u2 phy Macpaul Lin
2020-04-17 5:34 ` Chunfeng Yun
2020-04-29 21:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429213034.GA29572@bogus \
--to=robh@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@gmail.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=min.Guo@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).