From: Stephen Kitt <steve@sk2.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/3] docs: sysctl/kernel: document ftrace entries
Date: Wed, 29 Apr 2020 22:56:56 +0200 [thread overview]
Message-ID: <20200429225656.43aed6f9@heffalump.sk2.org> (raw)
In-Reply-To: <20200428124133.0fbaf7c5@lwn.net>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On Tue, 28 Apr 2020 12:41:33 -0600, Jonathan Corbet <corbet@lwn.net> wrote:
> On Thu, 23 Apr 2020 20:36:50 +0200
> Stephen Kitt <steve@sk2.org> wrote:
> > Based on the ftrace documentation, the tp_printk boot parameter
> > documentation, and the implementation in kernel/trace/trace.c.
> >
> > Signed-off-by: Stephen Kitt <steve@sk2.org>
>
> This one could benefit from an ack from Steve (CC'd). Also one other
> little nit below:
Thanks (and thanks for the review Steve). I’ll follow up with v2 shortly,
fixing the spelling and grammar here:
> > +the console. This is very useful for capturing traces that lead to
> > +crashes and outputing it to a serial console.
in addition to this:
> > +will stop tracepoints from being sent to printk(), and
> > +
> > +::
>
> I would just make that ", and::" and avoid the separate line.
Regards,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-29 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 18:36 [PATCH 1/3] docs: sysctl/kernel: document cad_pid Stephen Kitt
2020-04-23 18:36 ` [PATCH 2/3] docs: sysctl/kernel: document ftrace entries Stephen Kitt
2020-04-28 18:41 ` Jonathan Corbet
2020-04-28 20:03 ` Steven Rostedt
2020-04-29 20:56 ` Stephen Kitt [this message]
2020-04-23 18:36 ` [PATCH 3/3] docs: sysctl/kernel: document firmware_config Stephen Kitt
2020-04-28 18:39 ` [PATCH 1/3] docs: sysctl/kernel: document cad_pid Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429225656.43aed6f9@heffalump.sk2.org \
--to=steve@sk2.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).