From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03694C83004 for ; Thu, 30 Apr 2020 02:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9F40208E0 for ; Thu, 30 Apr 2020 02:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbgD3CJD (ORCPT ); Wed, 29 Apr 2020 22:09:03 -0400 Received: from mga07.intel.com ([134.134.136.100]:43401 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgD3CJC (ORCPT ); Wed, 29 Apr 2020 22:09:02 -0400 IronPort-SDR: JJQalPwEsayv6UwnqOebbrTxeM+fgFr3y+HoOkUQpvPkC8jj6Vv+sEJqgd374U0/0nvhYjEKYt UGrjBZGhyRMw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 19:09:01 -0700 IronPort-SDR: zBgAtl8/TZEyl3/1bRQfDWBdxpFSgnk1pqExldm0ubv31vBu/ATCmg7epE00CadkKK/EBaWmYZ mLVvSnkxADDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="405242122" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga004.jf.intel.com with ESMTP; 29 Apr 2020 19:09:01 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id C52C8301AAA; Wed, 29 Apr 2020 19:09:01 -0700 (PDT) Date: Wed, 29 Apr 2020 19:09:01 -0700 From: Andi Kleen To: Stephane Eranian Cc: LKML , Peter Zijlstra , mingo@elte.hu, Arnaldo Carvalho de Melo , Jiri Olsa , Ian Rogers , "Liang, Kan" Subject: Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs() Message-ID: <20200430020901.GC874567@tassilo.jf.intel.com> References: <20200418231908.152212-1-eranian@google.com> <20200428024744.GA703870@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I was under the impression that perf script was generating one line > per sample. Otherwise, seems hard to parse. That's only true for simple cases. A lot of the extended output options have long generated multiple lines. And of course call stacks always did. > Could you give me the cmdline options of perf script that justify the newline. e.g. perf script -F iregs,uregs -Andi