From: Lee Jones <lee.jones@linaro.org>
To: Dilip Kota <eswara.kota@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kishon@ti.com, vkoul@kernel.org,
devicetree@vger.kernel.org, arnd@arndb.de, robh@kernel.org,
andriy.shevchenko@intel.com, cheol.yong.kim@intel.com,
chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com,
yixin.zhu@intel.com
Subject: Re: [PATCH v7 0/3] Add Intel ComboPhy driver
Date: Thu, 30 Apr 2020 11:09:33 +0100 [thread overview]
Message-ID: <20200430100933.GA298816@dell> (raw)
In-Reply-To: <cbeeda50-1ac8-7b4e-2df5-94049b1cf6b9@linux.intel.com>
On Thu, 30 Apr 2020, Dilip Kota wrote:
>
> On 4/30/2020 4:25 PM, Lee Jones wrote:
> > On Thu, 30 Apr 2020, Dilip Kota wrote:
> >
> > > This patch series adds Intel ComboPhy driver, respective yaml schemas
> > >
> > > Changes on v7:
> > > As per System control driver maintainer's inputs remove
> > > fwnode_to_regmap() definition and use device_node_get_regmap()
> > > Changes on v6:
> > > Rebase patches on the latest maintainer's branch
> > > https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/?h=phy-for-5.7
> > > Dilip Kota (3):
> > > dt-bindings: phy: Add PHY_TYPE_XPCS definition
> > > dt-bindings: phy: Add YAML schemas for Intel ComboPhy
> > > phy: intel: Add driver support for ComboPhy
> > >
> > > .../devicetree/bindings/phy/intel,combo-phy.yaml | 101 ++++
> > > drivers/phy/intel/Kconfig | 14 +
> > > drivers/phy/intel/Makefile | 1 +
> > > drivers/phy/intel/phy-intel-combo.c | 627 +++++++++++++++++++++
> > > include/dt-bindings/phy/phy.h | 1 +
> > Why have you sent this to me?
> The main reason for this patch series is removing fwnode_to_regmap() and
> using device_node_get_regmap() compared to previous patch series.
> This has been done as per your review comments.
I see. Yes, dropping fwnode_to_regmap() was the right thing to do.
> To keep you updated that changes are done as per your review comments, sent
> to you along with PHY maintainers.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-04-30 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 7:15 [PATCH v7 0/3] Add Intel ComboPhy driver Dilip Kota
2020-04-30 7:15 ` [PATCH v7 1/3] dt-bindings: phy: Add PHY_TYPE_XPCS definition Dilip Kota
2020-04-30 7:15 ` [PATCH v7 2/3] dt-bindings: phy: Add YAML schemas for Intel ComboPhy Dilip Kota
2020-04-30 7:15 ` [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy Dilip Kota
2020-05-04 7:29 ` Vinod Koul
2020-05-04 8:26 ` Dilip Kota
2020-05-04 9:20 ` Vinod Koul
2020-05-04 9:32 ` Dilip Kota
2020-05-05 5:21 ` Vinod Koul
2020-05-05 7:54 ` Dilip Kota
2020-05-11 10:06 ` Dilip Kota
2020-04-30 8:25 ` [PATCH v7 0/3] Add Intel ComboPhy driver Lee Jones
2020-04-30 9:43 ` Dilip Kota
2020-04-30 10:09 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430100933.GA298816@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=yixin.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).