From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71FEC4724C for ; Thu, 30 Apr 2020 14:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C140620774 for ; Thu, 30 Apr 2020 14:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbgD3OPZ (ORCPT ); Thu, 30 Apr 2020 10:15:25 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:59711 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbgD3OPY (ORCPT ); Thu, 30 Apr 2020 10:15:24 -0400 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id D1D30240003; Thu, 30 Apr 2020 14:15:20 +0000 (UTC) Date: Thu, 30 Apr 2020 16:15:20 +0200 From: Alexandre Belloni To: Rob Herring Cc: Thierry Reding , Lee Jones , Alessandro Zummo , Jon Hunter , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: mfd: Document the RTC present on MAX77620 Message-ID: <20200430141520.GA101194@piout.net> References: <20200417170825.2551367-1-thierry.reding@gmail.com> <20200430140701.GA21776@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430140701.GA21776@bogus> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/2020 09:07:01-0500, Rob Herring wrote: > On Fri, Apr 17, 2020 at 07:08:23PM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > The RTC present on MAX77620 can be used to generate an alarm at a given > > time, which in turn can be used as a wakeup source for the system if it > > is properly wired up. > > > > Document how to enable the RTC to act as a wakeup source. > > > > Signed-off-by: Thierry Reding > > --- > > .../devicetree/bindings/mfd/max77620.txt | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/max77620.txt b/Documentation/devicetree/bindings/mfd/max77620.txt > > index 5a642a51d58e..f05005b0993e 100644 > > --- a/Documentation/devicetree/bindings/mfd/max77620.txt > > +++ b/Documentation/devicetree/bindings/mfd/max77620.txt > > @@ -125,6 +125,17 @@ MAX77663 supports 20, 40, 80, 160, 320, 640, 1280 and 2540 microseconds. > > control) then, GPIO1/nRST_IO goes LOW. > > this property is valid for max20024 only. > > > > +Realtime Clock > > +-------------- > > +The MAX77620 family of power management ICs contain a realtime clock block > > +that can be used to keep track of time even when the system is powered off. > > + > > +The realtime clock can also be programmed to trigger alerts, which can be > > +used to wake the system up from sleep. In order to configure the RTC to act > > +as a wakeup source, add an "rtc" child node and add the "wakeup-source" > > +property. > > + > > + > > For DT binding details of different sub modules like GPIO, pincontrol, > > regulator, power, please refer respective device-tree binding document > > under their respective sub-system directories. > > @@ -159,4 +170,8 @@ max77620@3c { > > maxim,fps-event-source = ; > > }; > > }; > > + > > + rtc { > > + wakeup-source; > > Is the RTC really the only thing that could wake the system in this > PMIC? > > I don't think it's really valid to have 'wakeup-source' without > 'interrupts' unless the wakeup mechanism is somehow not an interrupt. So > I think this belongs in the parent node. > I don't think this is true because in the case of a discrete RTC, its interrupt pin can be connected directly to a PMIC to power up a board instead of being connected to the SoC. In that case we don't have an interrupt property but the RTC is still a wakeup source. This is the usual use case for wakeup-source in the RTC subsystem. Else, if there is an interrupt, then we assume the RTC is a wakeup source and there is no need to have the wakeup-source property. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com