From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE99C47253 for ; Fri, 1 May 2020 13:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99B64208DB for ; Fri, 1 May 2020 13:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339593; bh=p7NXgcApTJu4tdB8OFmEnv8NlQcDY3n67zyaQo0S7pQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VfLQrcTwvHngqnO32yf418ZF0i/xLql4Ho9H1Z/NJXKVVtAMsrCASFroVPiYWV3Go f2l5WgBdApKxlmf7kRiKD/ffqI+42CgoxGuVo8MMdubDEjCVPMNDy4wExw+8SRfNKs 8O0Jhp2hpnP01U6QkePTxRRYVfQuwBUmEGjsQ3aI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729274AbgEAN0c (ORCPT ); Fri, 1 May 2020 09:26:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:48212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729258AbgEAN03 (ORCPT ); Fri, 1 May 2020 09:26:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23DFB2166E; Fri, 1 May 2020 13:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339588; bh=p7NXgcApTJu4tdB8OFmEnv8NlQcDY3n67zyaQo0S7pQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hfLPmbS29r5a5YLPIiJEmao32JnAPt6XFXpbcLyTOlCVJTJASkDTNmhZ3eEQNWoG+ mPO6bVm56xOaNYJD6uS8DiUN/139fCHzf2kTZcF8cfCMduVbKUKFls9Ov8zCKjSzda Z8ALEtDzUO7kcgzlrNbfIaBtU3iwt1sKzQOLlGM8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Malcolm Priestley Subject: [PATCH 4.4 50/70] staging: vt6656: Power save stop wake_up_count wrap around. Date: Fri, 1 May 2020 15:21:38 +0200 Message-Id: <20200501131528.881865283@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.302599262@linuxfoundation.org> References: <20200501131513.302599262@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Malcolm Priestley commit ea81c3486442f4643fc9825a2bb1b430b829bccd upstream. conf.listen_interval can sometimes be zero causing wake_up_count to wrap around up to many beacons too late causing CTRL-EVENT-BEACON-LOSS as in. wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ] Fixes: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.") Cc: stable Signed-off-by: Malcolm Priestley Link: https://lore.kernel.org/r/fce47bb5-7ca6-7671-5094-5c6107302f2b@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6656/int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6656/int.c +++ b/drivers/staging/vt6656/int.c @@ -157,7 +157,8 @@ void vnt_int_process_data(struct vnt_pri priv->wake_up_count = priv->hw->conf.listen_interval; - --priv->wake_up_count; + if (priv->wake_up_count) + --priv->wake_up_count; /* Turn on wake up to listen next beacon */ if (priv->wake_up_count == 1)