From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C40C47253 for ; Fri, 1 May 2020 13:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBA45208DB for ; Fri, 1 May 2020 13:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339630; bh=6ztxaQqiGIA1m1sIcnvYH1NX9Mz0deoFS5BI/XcdXkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wZ2YrDueqfxcquWlNjnhOsfeWmpkEznHztbCO0ZV1GqvVteymctug/k4+4fzVXS4y IxAYi2uZyaqQQXTe7T02YNaHxdQYjWf71hKCL3Rnf0rgyZEVyWpII1n+yaWBvChLoU AO78+M0JbRsLagakjuFdkx8kJCdFT07IrCI3ShMc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728894AbgEAN1K (ORCPT ); Fri, 1 May 2020 09:27:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:49188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729392AbgEAN1G (ORCPT ); Fri, 1 May 2020 09:27:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FD37208D6; Fri, 1 May 2020 13:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339625; bh=6ztxaQqiGIA1m1sIcnvYH1NX9Mz0deoFS5BI/XcdXkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hnemTW6dVImfZ+WDfFb+iZR264K/4CMfNpohGbUD5S6n0vJEPYn2oW0wTEj49Qm1O IKuZAtZewe4iU+bTmN8gYuPwddNG38LyxPtXnfThjvMSnrebgvBHNEicKWqdRefS0z 4Tk/08rvJNmuNkX0IU0XLNm876UePZR2z/hzRZCE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Erhard F." , Frank Rowand , Rob Herring , Sasha Levin Subject: [PATCH 4.4 65/70] of: unittest: kmemleak on changeset destroy Date: Fri, 1 May 2020 15:21:53 +0200 Message-Id: <20200501131532.508180734@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.302599262@linuxfoundation.org> References: <20200501131513.302599262@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand [ Upstream commit b3fb36ed694b05738d45218ea72cf7feb10ce2b1 ] kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 1 of 5. of_unittest_changeset() reaches deeply into the dynamic devicetree functions. Several nodes were left with an elevated reference count and thus were not properly cleaned up. Fix the reference counts so that the memory will be freed. Fixes: 201c910bd689 ("of: Transactional DT support.") Reported-by: Erhard F. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Sasha Levin --- drivers/of/unittest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 91e6891b777b6..109497dbfba08 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -544,6 +544,10 @@ static void __init of_unittest_changeset(void) mutex_unlock(&of_mutex); of_changeset_destroy(&chgset); + + of_node_put(n1); + of_node_put(n2); + of_node_put(n21); #endif } -- 2.20.1