From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D3BC4724C for ; Fri, 1 May 2020 13:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CEE9208D6 for ; Fri, 1 May 2020 13:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339841; bh=JcTR8buJrcrSvAWGM4jhzwvVThj9pWLXakvE+Oissvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KENdiIu6LCspgxM5P0kPF4a1IudQzANW35mMot0UM8b8Z8rvXR97ccDqR4h5uWjsR vgxk9P560O9U1ePDS622gwYC/RmeZCFA+OFWfudYMGTfkMfENfmKdQWQhp4Qva9/WL obPzBC69exsmJSS9ZODf/l0T10QcCdi/0t6f6t9U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729996AbgEANak (ORCPT ); Fri, 1 May 2020 09:30:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:54720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729974AbgEANah (ORCPT ); Fri, 1 May 2020 09:30:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE13220757; Fri, 1 May 2020 13:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339837; bh=JcTR8buJrcrSvAWGM4jhzwvVThj9pWLXakvE+Oissvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sHCQ2hFdgA1xw2kgIHd1Iw5pbyfYideIM+0U20VAejp/4UO2abWL8HOsMAnlvBMj0 bwKxgab8R7A/Haeu49pf3c6W7M4t7B9diXxhiveIKsYo2BZjmiUqMj0dR9kCNpsa8j qFB7lEgho/Tu+KmATy6kFZZDf3i1FEHc22yYWgL0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Brian Foster , Sasha Levin Subject: [PATCH 4.9 67/80] xfs: fix partially uninitialized structure in xfs_reflink_remap_extent Date: Fri, 1 May 2020 15:22:01 +0200 Message-Id: <20200501131534.974029037@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.810761598@linuxfoundation.org> References: <20200501131513.810761598@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Darrick J. Wong [ Upstream commit c142932c29e533ee892f87b44d8abc5719edceec ] In the reflink extent remap function, it turns out that uirec (the block mapping corresponding only to the part of the passed-in mapping that got unmapped) was not fully initialized. Specifically, br_state was not being copied from the passed-in struct to the uirec. This could lead to unpredictable results such as the reflinked mapping being marked unwritten in the destination file. Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster Signed-off-by: Sasha Levin --- fs/xfs/xfs_reflink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 17d3c964a2a23..6b753b969f7b8 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1162,6 +1162,7 @@ xfs_reflink_remap_extent( uirec.br_startblock = irec->br_startblock + rlen; uirec.br_startoff = irec->br_startoff + rlen; uirec.br_blockcount = unmap_len - rlen; + uirec.br_state = irec->br_state; unmap_len = rlen; /* If this isn't a real mapping, we're done. */ -- 2.20.1