From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD0BC47253 for ; Fri, 1 May 2020 13:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 120BC208DB for ; Fri, 1 May 2020 13:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340480; bh=h+yf3XfLMMIBkEtIRS1gwvCxk7zvY/MZ7YG4iM+WI90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HgMjJTKDC2rdfU1e/buFKyD/ChGibtGOZlcaMETPG/sa+TLyrmcaArZvnwLt8Gyno n/4wJ5TdkvWo4oZo++ZsosesOQDrcsdUNOgpaQ6NAys80ISpJ6i6aEUDCnU3NWCtlc GEqiJjPvmImoH/GCdH+v52QzaLyhjdx/DfoAsbL4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731107AbgEANlT (ORCPT ); Fri, 1 May 2020 09:41:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:41410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731397AbgEANlK (ORCPT ); Fri, 1 May 2020 09:41:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 488D9205C9; Fri, 1 May 2020 13:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340469; bh=h+yf3XfLMMIBkEtIRS1gwvCxk7zvY/MZ7YG4iM+WI90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oUv08YIFvjhZrCtPjdgPK1DpgJdd3xm1jBSd0ympVSu7wh6MiXbcNN6S4h4HyRim+ m1JpFjyjTLGdpWD7CnD36mC66vAI29ahsENQivtBEYioae8jESsDYdy9PFz65+vmJR Lk/xAseaNfmI7rnG2PoPrYZ5/KFdDUyss/Z9JHvo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Olivier Moysan , Mark Brown Subject: [PATCH 5.4 83/83] ASoC: stm32: spdifrx: fix regmap status check Date: Fri, 1 May 2020 15:24:02 +0200 Message-Id: <20200501131543.348279295@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131524.004332640@linuxfoundation.org> References: <20200501131524.004332640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olivier Moysan commit a168dae5ea14283e8992d5282237bb0d6a3e1c06 upstream. Release resources when exiting on error. Fixes: 1a5c0b28fc56 ("ASoC: stm32: spdifrx: manage identification registers") Signed-off-by: Olivier Moysan Link: https://lore.kernel.org/r/20200318144125.9163-2-olivier.moysan@st.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/stm/stm32_spdifrx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -995,6 +995,8 @@ static int stm32_spdifrx_probe(struct pl if (idr == SPDIFRX_IPIDR_NUMBER) { ret = regmap_read(spdifrx->regmap, STM32_SPDIFRX_VERR, &ver); + if (ret) + goto error; dev_dbg(&pdev->dev, "SPDIFRX version: %lu.%lu registered\n", FIELD_GET(SPDIFRX_VERR_MAJ_MASK, ver),