From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6556C4724C for ; Fri, 1 May 2020 13:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF4B920836 for ; Fri, 1 May 2020 13:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588341296; bh=eBCDuPALBjblZY2LghskzU/XNf5BeiTBZEoKVOn2SMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2OA/h+xHy0jh+8lf7jyuH6bxvapkGHLb+52nY34DFixDcOKWP7llONxLSp71ix/aU WL7kFHTuehZRywsVCMX2W/OpPsKckYdNuV4Ypo4XVhXnnRf0/PNQP6C4UM7CEULsHO bx5Q+cmVG6c1GnDvZGrWVAaAMg9Fjem0o+ZAUH2c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730599AbgEANyz (ORCPT ); Fri, 1 May 2020 09:54:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:32874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730606AbgEANep (ORCPT ); Fri, 1 May 2020 09:34:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85BAE216FD; Fri, 1 May 2020 13:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340085; bh=eBCDuPALBjblZY2LghskzU/XNf5BeiTBZEoKVOn2SMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cqrwaR464Bfkzf9ZIKmH2N6Xl8nlnYajVATTfudi/uvujSSvyR/23dFptKU5axLXY hS8z77+5Tq3GzTI74+AsQiAPRRsw89MI53IejW4U3f9jSPm2gMcejaKSbeTq62Vujr cr67+jnegQf+jwGnbMZOBJpVLjQsQ1LLEkRy090Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Brian Foster , Sasha Levin Subject: [PATCH 4.14 100/117] xfs: fix partially uninitialized structure in xfs_reflink_remap_extent Date: Fri, 1 May 2020 15:22:16 +0200 Message-Id: <20200501131557.568361792@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131544.291247695@linuxfoundation.org> References: <20200501131544.291247695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Darrick J. Wong [ Upstream commit c142932c29e533ee892f87b44d8abc5719edceec ] In the reflink extent remap function, it turns out that uirec (the block mapping corresponding only to the part of the passed-in mapping that got unmapped) was not fully initialized. Specifically, br_state was not being copied from the passed-in struct to the uirec. This could lead to unpredictable results such as the reflinked mapping being marked unwritten in the destination file. Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster Signed-off-by: Sasha Levin --- fs/xfs/xfs_reflink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 37e603bf15913..db7f9fdd20a30 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1125,6 +1125,7 @@ xfs_reflink_remap_extent( uirec.br_startblock = irec->br_startblock + rlen; uirec.br_startoff = irec->br_startoff + rlen; uirec.br_blockcount = unmap_len - rlen; + uirec.br_state = irec->br_state; unmap_len = rlen; /* If this isn't a real mapping, we're done. */ -- 2.20.1