From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A89C4724C for ; Fri, 1 May 2020 13:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC5EB2051A for ; Fri, 1 May 2020 13:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588341245; bh=UqhS9hHQWgitHhDrsu7ZAJsA5DU3n0Sh+/M/qt600UU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0GPuMOYl1tWCo6axmF8lAtts+tRNJ+YwwSJYGnFcZA5DdAg9IbHDmWLgSOF0aSk+M +pHmGVE6NNOohIouwwHrkwxRDJ0Eeisc2JjNOC+JZ1cVgxszNNVQUPfTTEFmyZeJwF f3SubibUNB/frhiChMaO/e14Tj82FAL8SF+0ZLVk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731938AbgEANyF (ORCPT ); Fri, 1 May 2020 09:54:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:33966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729683AbgEANfj (ORCPT ); Fri, 1 May 2020 09:35:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C965208DB; Fri, 1 May 2020 13:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340138; bh=UqhS9hHQWgitHhDrsu7ZAJsA5DU3n0Sh+/M/qt600UU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WRapGDqqtvSZd1hKkdp88Mueo22xo6gaazxM2x3zgypHYuzo0vZd1ixWKchLQhFxN S3NVvurmgX+0+QlNkhthi/6NFHZaS15h4VcGswqiiH0O1ZY5bN1ESvWmaNQbUDLTmG As4LhTy0JkaLSuLOli2gHCAu8Y5I25pYLcI00rig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Erhard F." , Frank Rowand , Rob Herring , Sasha Levin Subject: [PATCH 4.14 109/117] of: unittest: kmemleak on changeset destroy Date: Fri, 1 May 2020 15:22:25 +0200 Message-Id: <20200501131558.164939029@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131544.291247695@linuxfoundation.org> References: <20200501131544.291247695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand [ Upstream commit b3fb36ed694b05738d45218ea72cf7feb10ce2b1 ] kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 1 of 5. of_unittest_changeset() reaches deeply into the dynamic devicetree functions. Several nodes were left with an elevated reference count and thus were not properly cleaned up. Fix the reference counts so that the memory will be freed. Fixes: 201c910bd689 ("of: Transactional DT support.") Reported-by: Erhard F. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Sasha Levin --- drivers/of/unittest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 55c98f119df22..e7e6dd07f2150 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -605,6 +605,10 @@ static void __init of_unittest_changeset(void) unittest(!of_changeset_revert(&chgset), "revert failed\n"); of_changeset_destroy(&chgset); + + of_node_put(n1); + of_node_put(n2); + of_node_put(n21); #endif } -- 2.20.1