From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B75C4724C for ; Fri, 1 May 2020 14:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3DEF20708 for ; Fri, 1 May 2020 14:37:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V/vELu92" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729108AbgEAOha (ORCPT ); Fri, 1 May 2020 10:37:30 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:23730 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728894AbgEAOh2 (ORCPT ); Fri, 1 May 2020 10:37:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588343847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+pSfuYwc07hQQ9dsDKJcYfTJmTKhIXhBIr9mDnsaJ8=; b=V/vELu92n/llXKABrwdcbvZVQa2U0QuCDqaM+T2xpi/p4xI32Ui1Gv6D8skYLnAz47Akt1 9gs0TId5z2f/MbuWuNARbKwlmdBJ8CnfH2i9WpziCD1dBPQjhv8Hfmvau7Tuhrsbx5/9Lv 8xOVtxpND+jTrDLBsk6AzR+Mkw3WdMo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-nN46WyfNNZ-zHl2ISgAVZw-1; Fri, 01 May 2020 10:37:22 -0400 X-MC-Unique: nN46WyfNNZ-zHl2ISgAVZw-1 Received: by mail-wm1-f69.google.com with SMTP id v185so2124020wmg.0 for ; Fri, 01 May 2020 07:37:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=I+pSfuYwc07hQQ9dsDKJcYfTJmTKhIXhBIr9mDnsaJ8=; b=XBFENZyOCZCkvgpoIZb7ekzQD3eMmq33LsO/QuvTq/0KBWV07Xnru9chWfyL6wbQbl O9yDBEEw5/r1Obl2ktvcA/oanX0FsTcxtUBmAgF69n588orJ2bTItBVAEFl9b3Mg7BLZ XBcAAiWeNqZHLG7HoPnxhZh/sLYLfapdC2GlerIYcqKvMvCKCTSfFFSoTjIQhvs0kyR+ kKKoQ+NTSVkiNtD+TWEQ/bzErGAIYhQgYjDzzrWvVE1zOeM2d1i1V1xyqzLKo5rrC7Y3 iQwZAthS7zfmhzvEWLH7YPOe+l96Gj3OG4KMqgAVD2peCe3dDwE22k1SNfbjEJnpqSrw o5Og== X-Gm-Message-State: AGi0PubfcAhhFxqaUJ7Q6YKHyvh7r0aN+tJP0ajtz1xo83ftGFUxP0+C f7nFZaavlMaNyoswI37e0g1MmKVNVG6qHIVLm1I9OdZivA7fZC14Xgx5BAq05LFixLGquaEioev mdFLDWH5BZK9u4jxzEBRM2uTj X-Received: by 2002:a1c:1d4b:: with SMTP id d72mr4150357wmd.19.1588343840465; Fri, 01 May 2020 07:37:20 -0700 (PDT) X-Google-Smtp-Source: APiQypKHqBQQRlsc1K8bjThQcoW9mKD/VyXIIHA6zpDxxO2WCF7VUxpGnsPXDB+8huVAz76rKrLJPQ== X-Received: by 2002:a1c:1d4b:: with SMTP id d72mr4150333wmd.19.1588343840150; Fri, 01 May 2020 07:37:20 -0700 (PDT) Received: from steredhat (host108-207-dynamic.49-79-r.retail.telecomitalia.it. [79.49.207.108]) by smtp.gmail.com with ESMTPSA id r20sm4024126wmh.26.2020.05.01.07.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 07:37:19 -0700 (PDT) Date: Fri, 1 May 2020 16:37:16 +0200 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: Justin He , Stefan Hajnoczi , Jason Wang , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kaly Xin Subject: Re: [PATCH] vhost: vsock: don't send pkt when vq is not started Message-ID: <20200501143716.ln7hjh3vn77ng43i@steredhat> References: <20200430021314.6425-1-justin.he@arm.com> <20200430082608.wbtqgglmtnd7e5ci@steredhat> <20200430162521.k4b4t3vttfabgqal@steredhat> <20200430153929-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200430153929-mutt-send-email-mst@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 03:43:00PM -0400, Michael S. Tsirkin wrote: > On Thu, Apr 30, 2020 at 06:25:21PM +0200, Stefano Garzarella wrote: > > On Thu, Apr 30, 2020 at 10:06:26AM +0000, Justin He wrote: > > > Hi Stefano > > > > > > > -----Original Message----- > > > > From: Stefano Garzarella > > > > Sent: Thursday, April 30, 2020 4:26 PM > > > > To: Justin He > > > > Cc: Stefan Hajnoczi ; Michael S. Tsirkin > > > > ; Jason Wang ; > > > > kvm@vger.kernel.org; virtualization@lists.linux-foundation.org; > > > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Kaly Xin > > > > > > > > Subject: Re: [PATCH] vhost: vsock: don't send pkt when vq is not started > > > > > > > > Hi Jia, > > > > thanks for the patch, some comments below: > > > > > > > > On Thu, Apr 30, 2020 at 10:13:14AM +0800, Jia He wrote: > > > > > Ning Bo reported an abnormal 2-second gap when booting Kata container > > > > [1]. > > > > > The unconditional timeout is caused by > > > > VSOCK_DEFAULT_CONNECT_TIMEOUT of > > > > > connect at client side. The vhost vsock client tries to connect an > > > > > initlizing virtio vsock server. > > > > > > > > > > The abnormal flow looks like: > > > > > host-userspace vhost vsock guest vsock > > > > > ============== =========== ============ > > > > > connect() --------> vhost_transport_send_pkt_work() initializing > > > > > | vq->private_data==NULL > > > > > | will not be queued > > > > > V > > > > > schedule_timeout(2s) > > > > > vhost_vsock_start() <--------- device ready > > > > > set vq->private_data > > > > > > > > > > wait for 2s and failed > > > > > > > > > > connect() again vq->private_data!=NULL recv connecting pkt > > > > > > > > > > 1. host userspace sends a connect pkt, at that time, guest vsock is under > > > > > initializing, hence the vhost_vsock_start has not been called. So > > > > > vq->private_data==NULL, and the pkt is not been queued to send to guest. > > > > > 2. then it sleeps for 2s > > > > > 3. after guest vsock finishes initializing, vq->private_data is set. > > > > > 4. When host userspace wakes up after 2s, send connecting pkt again, > > > > > everything is fine. > > > > > > > > > > This fixes it by checking vq->private_data in vhost_transport_send_pkt, > > > > > and return at once if !vq->private_data. This makes user connect() > > > > > be returned with ECONNREFUSED. > > > > > > > > > > After this patch, kata-runtime (with vsock enabled) boottime reduces from > > > > > 3s to 1s on ThunderX2 arm64 server. > > > > > > > > > > [1] https://github.com/kata-containers/runtime/issues/1917 > > > > > > > > > > Reported-by: Ning Bo > > > > > Signed-off-by: Jia He > > > > > --- > > > > > drivers/vhost/vsock.c | 8 ++++++++ > > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c > > > > > index e36aaf9ba7bd..67474334dd88 100644 > > > > > --- a/drivers/vhost/vsock.c > > > > > +++ b/drivers/vhost/vsock.c > > > > > @@ -241,6 +241,7 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt > > > > *pkt) > > > > > { > > > > > struct vhost_vsock *vsock; > > > > > int len = pkt->len; > > > > > +struct vhost_virtqueue *vq; > > > > > > > > > > rcu_read_lock(); > > > > > > > > > > @@ -252,6 +253,13 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt > > > > *pkt) > > > > > return -ENODEV; > > > > > } > > > > > > > > > > +vq = &vsock->vqs[VSOCK_VQ_RX]; > > > > > +if (!vq->private_data) { > > > > > > > > I think is better to use vhost_vq_get_backend(): > > > > > > > > if (!vhost_vq_get_backend(&vsock->vqs[VSOCK_VQ_RX])) { > > > > ... > > > > > > > > This function should be called with 'vq->mutex' acquired as explained in > > > > the comment, but here we can avoid that, because we are not using the vq, > > > > so it is safe, because in vhost_transport_do_send_pkt() we check it again. > > > > > > > > Please add a comment explaining that. > > > > > > > > > > Thanks, vhost_vq_get_backend is better. I chose a 5.3 kernel to develop > > > and missed this helper. > > > > :-) > > > > > > > > > > As an alternative to this patch, should we kick the send worker when the > > > > device is ready? > > > > > > > > IIUC we reach the timeout because the send worker (that runs > > > > vhost_transport_do_send_pkt()) exits immediately since 'vq->private_data' > > > > is NULL, and no one will requeue it. > > > > > > > > Let's do it when we know the device is ready: > > > > > > > > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c > > > > index e36aaf9ba7bd..295b5867944f 100644 > > > > --- a/drivers/vhost/vsock.c > > > > +++ b/drivers/vhost/vsock.c > > > > @@ -543,6 +543,11 @@ static int vhost_vsock_start(struct vhost_vsock > > > > *vsock) > > > > mutex_unlock(&vq->mutex); > > > > } > > > > > > > > + /* Some packets may have been queued before the device was started, > > > > + * let's kick the send worker to send them. > > > > + */ > > > > + vhost_work_queue(&vsock->dev, &vsock->send_pkt_work); > > > > + > > > Yes, it works. > > > But do you think a threshold should be set here to prevent the queue > > > from being too long? E.g. the client user sends too many connect pkts > > > in a short time before the server is completely ready. > > > > When the user call the connect() the socket status is moved to > > SS_CONNECTING (see net/vmw_vsock/af_vsock.c), so another connect() on > > the same socket will receive EALREADY error. > > > > If the user uses multiple sockets, the socket layer already check for > > any limits, so I don't think we should put a threshold here. > > > > > > > > > mutex_unlock(&vsock->dev.mutex); > > > > return 0; > > > > > > > > I didn't test it, can you try if it fixes the issue? > > > > > > > > I'm not sure which is better... > > > I don't know, either. Wait for more comments 😊 > > > > I prefer the second option, because the device is in a transitional > > state and a connect can block (for at most two seconds) until the device is > > started. > > > > For the first option, I'm also not sure if ECONNREFUSED is the right error > > to return, maybe is better ENETUNREACH. > > > > Cheers, > > Stefano > > IIRC: > > ECONNREFUSED is what one gets when connecting to remote a port which does not > yet have a listening socket, so remote sends back RST. > ENETUNREACH is when local network's down, so you can't even send a > connection request. > EHOSTUNREACH is remote network is down. Thanks for the clarification! I was looking at connect(2) man page and there isn't EHOSTUNREACH in the ERRORS section :-( But connect(3p) contains the following that match what you said: ECONNRESET Remote host reset the connection request. ENETUNREACH No route to the network is present. EHOSTUNREACH The destination host cannot be reached (probably because the host is down or a remote router cannot reach it). So in this case, I think ENETUNREACH should be the best one, since the device is down and we can't send the connection request, but also EHOSTUNREACH should fit... In af_vsock.c we already return ENETUNREACH when the stream is not allowed or we don't have a transport to use. Thanks, Stefano