From: Andrew Morton <akpm@linux-foundation.org>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org,
cl@linux.com
Subject: Re: [PATCH] mm: slub: add panic_on_error to the debug facilities
Date: Fri, 1 May 2020 14:37:51 -0700 [thread overview]
Message-ID: <20200501143751.97a25bb7f89f8d93ec443868@linux-foundation.org> (raw)
In-Reply-To: <20200501211540.71216-1-aquini@redhat.com>
On Fri, 1 May 2020 17:15:40 -0400 Rafael Aquini <aquini@redhat.com> wrote:
> Sometimes it is desirable to override SLUB's debug facilities
> default behavior upon stumbling on a cache or object error
> and just stop the execution in order to grab a coredump, at
> the error-spotting time, instead of trying to fix the issue
> and report in an attempt to keep the system rolling.
>
> This patch introduces a new debug flag SLAB_PANIC_ON_ERROR,
> along with its related SLUB-machinery, in order to extend
> current slub_debug facilites and provide the aforementioned
> behavior override.
>
Sees reasonable.
> --- a/Documentation/vm/slub.rst
> +++ b/Documentation/vm/slub.rst
> @@ -54,6 +54,8 @@ Possible debug options are::
> caused higher minimum slab orders
> - Switch all debugging off (useful if the kernel is
> configured with CONFIG_SLUB_DEBUG_ON)
> + C Toggle panic on error (crash) to allow for post-mortem
> + analysis of a coredump taken at the error-spotting time
nit: "toggle" means to switch to the other state. But what we're doing
here is to set to the "on" state. This:
--- a/Documentation/vm/slub.rst~mm-slub-add-panic_on_error-to-the-debug-facilities-fix
+++ a/Documentation/vm/slub.rst
@@ -49,12 +49,12 @@ Possible debug options are::
P Poisoning (object and padding)
U User tracking (free and alloc)
T Trace (please only use on single slabs)
- A Toggle failslab filter mark for the cache
+ A Enable failslab filter mark for the cache
O Switch debugging off for caches that would have
caused higher minimum slab orders
- Switch all debugging off (useful if the kernel is
configured with CONFIG_SLUB_DEBUG_ON)
- C Toggle panic on error (crash) to allow for post-mortem
+ C Enable panic on error (crash) to allow for post-mortem
analysis of a coredump taken at the error-spotting time
F.e. in order to boot just with sanity checks and red zoning one would specify::
_
next prev parent reply other threads:[~2020-05-01 21:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 21:15 [PATCH] mm: slub: add panic_on_error to the debug facilities Rafael Aquini
2020-05-01 21:29 ` Qian Cai
2020-05-01 21:54 ` Rafael Aquini
2020-05-01 22:00 ` Qian Cai
2020-05-01 23:17 ` Qian Cai
2020-05-04 2:36 ` Rafael Aquini
2020-05-01 21:37 ` Andrew Morton [this message]
2020-05-01 21:41 ` Rafael Aquini
2020-05-02 23:16 ` Christopher Lameter
2020-05-04 2:51 ` Rafael Aquini
2020-05-08 3:06 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501143751.97a25bb7f89f8d93ec443868@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).