* [PATCH v2] perf: cs-etm: Update to build with latest opencsd version.
@ 2020-05-01 14:36 Mike Leach
2020-05-01 15:22 ` Leo Yan
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mike Leach @ 2020-05-01 14:36 UTC (permalink / raw)
To: linux-arm-kernel, coresight, mathieu.poirier, linux-kernel
Cc: suzuki.poulose, peterz, mingo, acme, Mike Leach
OpenCSD version v0.14.0 adds in a new output element. This is represented
by a new value in the generic element type enum, which must be added to
the handling code in perf cs-etm-decoder to prevent build errors due to
build options on the perf project.
This element is not currently used by the perf decoder.
Perf build feature test updated to require a minimum of 0.14.0
Tested on Linux 5.7-rc3.
Signed-off-by: Mike Leach <mike.leach@linaro.org>
---
tools/build/feature/test-libopencsd.c | 4 ++--
tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c
index 2b0e02c38870..1547bc2c0950 100644
--- a/tools/build/feature/test-libopencsd.c
+++ b/tools/build/feature/test-libopencsd.c
@@ -4,9 +4,9 @@
/*
* Check OpenCSD library version is sufficient to provide required features
*/
-#define OCSD_MIN_VER ((0 << 16) | (11 << 8) | (0))
+#define OCSD_MIN_VER ((0 << 16) | (14 << 8) | (0))
#if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER)
-#error "OpenCSD >= 0.11.0 is required"
+#error "OpenCSD >= 0.14.0 is required"
#endif
int main(void)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
index cd92a99eb89d..cd007cc9c283 100644
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
@@ -564,6 +564,8 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
resp = cs_etm_decoder__set_tid(etmq, packet_queue,
elem, trace_chan_id);
break;
+ /* Unused packet types */
+ case OCSD_GEN_TRC_ELEM_I_RANGE_NOPATH:
case OCSD_GEN_TRC_ELEM_ADDR_NACC:
case OCSD_GEN_TRC_ELEM_CYCLE_COUNT:
case OCSD_GEN_TRC_ELEM_ADDR_UNKNOWN:
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] perf: cs-etm: Update to build with latest opencsd version.
2020-05-01 14:36 [PATCH v2] perf: cs-etm: Update to build with latest opencsd version Mike Leach
@ 2020-05-01 15:22 ` Leo Yan
2020-05-04 17:06 ` Mathieu Poirier
2020-05-08 13:04 ` [tip: perf/core] " tip-bot2 for Mike Leach
2 siblings, 0 replies; 5+ messages in thread
From: Leo Yan @ 2020-05-01 15:22 UTC (permalink / raw)
To: Mike Leach
Cc: linux-arm-kernel, coresight, mathieu.poirier, linux-kernel,
peterz, mingo, acme
On Fri, May 01, 2020 at 03:36:15PM +0100, Mike Leach wrote:
> OpenCSD version v0.14.0 adds in a new output element. This is represented
> by a new value in the generic element type enum, which must be added to
> the handling code in perf cs-etm-decoder to prevent build errors due to
> build options on the perf project.
>
> This element is not currently used by the perf decoder.
>
> Perf build feature test updated to require a minimum of 0.14.0
>
> Tested on Linux 5.7-rc3.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
Looks good to me, FWIW:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/build/feature/test-libopencsd.c | 4 ++--
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c
> index 2b0e02c38870..1547bc2c0950 100644
> --- a/tools/build/feature/test-libopencsd.c
> +++ b/tools/build/feature/test-libopencsd.c
> @@ -4,9 +4,9 @@
> /*
> * Check OpenCSD library version is sufficient to provide required features
> */
> -#define OCSD_MIN_VER ((0 << 16) | (11 << 8) | (0))
> +#define OCSD_MIN_VER ((0 << 16) | (14 << 8) | (0))
> #if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER)
> -#error "OpenCSD >= 0.11.0 is required"
> +#error "OpenCSD >= 0.14.0 is required"
> #endif
>
> int main(void)
> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> index cd92a99eb89d..cd007cc9c283 100644
> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> @@ -564,6 +564,8 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
> resp = cs_etm_decoder__set_tid(etmq, packet_queue,
> elem, trace_chan_id);
> break;
> + /* Unused packet types */
> + case OCSD_GEN_TRC_ELEM_I_RANGE_NOPATH:
> case OCSD_GEN_TRC_ELEM_ADDR_NACC:
> case OCSD_GEN_TRC_ELEM_CYCLE_COUNT:
> case OCSD_GEN_TRC_ELEM_ADDR_UNKNOWN:
> --
> 2.17.1
>
> _______________________________________________
> CoreSight mailing list
> CoreSight@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/coresight
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] perf: cs-etm: Update to build with latest opencsd version.
2020-05-01 14:36 [PATCH v2] perf: cs-etm: Update to build with latest opencsd version Mike Leach
2020-05-01 15:22 ` Leo Yan
@ 2020-05-04 17:06 ` Mathieu Poirier
2020-05-05 11:44 ` Arnaldo Carvalho de Melo
2020-05-08 13:04 ` [tip: perf/core] " tip-bot2 for Mike Leach
2 siblings, 1 reply; 5+ messages in thread
From: Mathieu Poirier @ 2020-05-04 17:06 UTC (permalink / raw)
To: Mike Leach
Cc: linux-arm-kernel, coresight, linux-kernel, suzuki.poulose,
peterz, mingo, acme
On Fri, May 01, 2020 at 03:36:15PM +0100, Mike Leach wrote:
> OpenCSD version v0.14.0 adds in a new output element. This is represented
> by a new value in the generic element type enum, which must be added to
> the handling code in perf cs-etm-decoder to prevent build errors due to
> build options on the perf project.
>
> This element is not currently used by the perf decoder.
>
> Perf build feature test updated to require a minimum of 0.14.0
>
> Tested on Linux 5.7-rc3.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> ---
> tools/build/feature/test-libopencsd.c | 4 ++--
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c
> index 2b0e02c38870..1547bc2c0950 100644
> --- a/tools/build/feature/test-libopencsd.c
> +++ b/tools/build/feature/test-libopencsd.c
> @@ -4,9 +4,9 @@
> /*
> * Check OpenCSD library version is sufficient to provide required features
> */
> -#define OCSD_MIN_VER ((0 << 16) | (11 << 8) | (0))
> +#define OCSD_MIN_VER ((0 << 16) | (14 << 8) | (0))
> #if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER)
> -#error "OpenCSD >= 0.11.0 is required"
> +#error "OpenCSD >= 0.14.0 is required"
> #endif
>
> int main(void)
> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> index cd92a99eb89d..cd007cc9c283 100644
> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> @@ -564,6 +564,8 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
> resp = cs_etm_decoder__set_tid(etmq, packet_queue,
> elem, trace_chan_id);
> break;
> + /* Unused packet types */
> + case OCSD_GEN_TRC_ELEM_I_RANGE_NOPATH:
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> case OCSD_GEN_TRC_ELEM_ADDR_NACC:
> case OCSD_GEN_TRC_ELEM_CYCLE_COUNT:
> case OCSD_GEN_TRC_ELEM_ADDR_UNKNOWN:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] perf: cs-etm: Update to build with latest opencsd version.
2020-05-04 17:06 ` Mathieu Poirier
@ 2020-05-05 11:44 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-05-05 11:44 UTC (permalink / raw)
To: Mathieu Poirier
Cc: Mike Leach, linux-arm-kernel, coresight, linux-kernel,
suzuki.poulose, peterz, mingo
Em Mon, May 04, 2020 at 11:06:18AM -0600, Mathieu Poirier escreveu:
> On Fri, May 01, 2020 at 03:36:15PM +0100, Mike Leach wrote:
> > OpenCSD version v0.14.0 adds in a new output element. This is represented
> > by a new value in the generic element type enum, which must be added to
> > the handling code in perf cs-etm-decoder to prevent build errors due to
> > build options on the perf project.
> >
> > This element is not currently used by the perf decoder.
> >
> > Perf build feature test updated to require a minimum of 0.14.0
> >
> > Tested on Linux 5.7-rc3.
> >
> > Signed-off-by: Mike Leach <mike.leach@linaro.org>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks, applied with both your and Leo's R-by tags.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: perf/core] perf: cs-etm: Update to build with latest opencsd version.
2020-05-01 14:36 [PATCH v2] perf: cs-etm: Update to build with latest opencsd version Mike Leach
2020-05-01 15:22 ` Leo Yan
2020-05-04 17:06 ` Mathieu Poirier
@ 2020-05-08 13:04 ` tip-bot2 for Mike Leach
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Mike Leach @ 2020-05-08 13:04 UTC (permalink / raw)
To: linux-tip-commits
Cc: Mike Leach, Leo Yan, Mathieu Poirier, Peter Zijlstra,
Suzuki Poulouse, coresight, linux-arm-kernel,
Arnaldo Carvalho de Melo, x86, LKML
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 29e2eb2a9e1fac8b320bf2b4c628c336afbdd84f
Gitweb: https://git.kernel.org/tip/29e2eb2a9e1fac8b320bf2b4c628c336afbdd84f
Author: Mike Leach <mike.leach@linaro.org>
AuthorDate: Fri, 01 May 2020 15:36:15 +01:00
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Tue, 05 May 2020 16:35:32 -03:00
perf: cs-etm: Update to build with latest opencsd version.
OpenCSD version v0.14.0 adds in a new output element. This is represented
by a new value in the generic element type enum, which must be added to
the handling code in perf cs-etm-decoder to prevent build errors due to
build options on the perf project.
This element is not currently used by the perf decoder.
Perf build feature test updated to require a minimum of 0.14.0
Tested on Linux 5.7-rc3.
Signed-off-by: Mike Leach <mike.leach@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lore.kernel.org/lkml/20200501143615.1180-1-mike.leach@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/build/feature/test-libopencsd.c | 4 ++--
tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c
index 2b0e02c..1547bc2 100644
--- a/tools/build/feature/test-libopencsd.c
+++ b/tools/build/feature/test-libopencsd.c
@@ -4,9 +4,9 @@
/*
* Check OpenCSD library version is sufficient to provide required features
*/
-#define OCSD_MIN_VER ((0 << 16) | (11 << 8) | (0))
+#define OCSD_MIN_VER ((0 << 16) | (14 << 8) | (0))
#if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER)
-#error "OpenCSD >= 0.11.0 is required"
+#error "OpenCSD >= 0.14.0 is required"
#endif
int main(void)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
index cd92a99..cd007cc 100644
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
@@ -564,6 +564,8 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
resp = cs_etm_decoder__set_tid(etmq, packet_queue,
elem, trace_chan_id);
break;
+ /* Unused packet types */
+ case OCSD_GEN_TRC_ELEM_I_RANGE_NOPATH:
case OCSD_GEN_TRC_ELEM_ADDR_NACC:
case OCSD_GEN_TRC_ELEM_CYCLE_COUNT:
case OCSD_GEN_TRC_ELEM_ADDR_UNKNOWN:
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-08 13:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01 14:36 [PATCH v2] perf: cs-etm: Update to build with latest opencsd version Mike Leach
2020-05-01 15:22 ` Leo Yan
2020-05-04 17:06 ` Mathieu Poirier
2020-05-05 11:44 ` Arnaldo Carvalho de Melo
2020-05-08 13:04 ` [tip: perf/core] " tip-bot2 for Mike Leach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).