From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45183C4724C for ; Fri, 1 May 2020 15:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2273A2173E for ; Fri, 1 May 2020 15:36:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gUq93X7u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729787AbgEAPgB (ORCPT ); Fri, 1 May 2020 11:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729192AbgEAPgA (ORCPT ); Fri, 1 May 2020 11:36:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95FEC061A0C; Fri, 1 May 2020 08:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HsrfycC9F4gKazlY38RjqD/p4LVNAXXHW9C6abpgCD4=; b=gUq93X7ub8035oC97Ilk3m/Oje QO28Jw9UtfshJEL1j7z4GkCeUtAeGUe3nwbyYz7rdav/6UzfN4WriB/Chnc4DtD4D+oB52TvqrdP5 5bIm8qgpd5B1H5ITfQl61+enY8j4KQ1xvx+ergx5pObGzDMU5b+ctje6L1tlDCCdXxd8f/VvasYAR VHDzsN0kXZ6dA3Codnydpt0fyWNQWzi0A4YWRM9dJ/Hj4/eTucDnmHfIR+9Te05t3cNLIsMXj/hne CGF3jp1gz2X8UQW74diVJJsxM9wTOTCPvSlLpQ0HpAraVWUHiaXRcGd3IxEMYfHRm+SRyRPkRslfu O5t1EV5Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUXho-0006lH-Gd; Fri, 01 May 2020 15:36:00 +0000 Date: Fri, 1 May 2020 08:36:00 -0700 From: Christoph Hellwig To: Denis Efremov Cc: linux-block@vger.kernel.org, Willy Tarreau , Christoph Hellwig , Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] floppy: add FD_AUTODETECT_SIZE define for struct floppy_drive_params Message-ID: <20200501153600.GC12469@infradead.org> References: <20200501134416.72248-1-efremov@linux.com> <20200501134416.72248-3-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501134416.72248-3-efremov@linux.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2020 at 04:44:14PM +0300, Denis Efremov wrote: > Use FD_AUTODETECT_SIZE for autodetect buffer size in struct > floppy_drive_params instead of a magic number. Looks good, Reviewed-by: Christoph Hellwig