* [PATCH] staging: wilc1000: Increase the size of wid_list array
@ 2020-05-01 17:02 Oscar Carter
2020-05-01 18:26 ` Ajay.Kathat
0 siblings, 1 reply; 3+ messages in thread
From: Oscar Carter @ 2020-05-01 17:02 UTC (permalink / raw)
To: Adham Abozaeid, Ajay Singh
Cc: Greg Kroah-Hartman, Rachel Kim, Johnny Kim, Chris Park, Dean Lee,
linux-wireless, devel, linux-kernel, Oscar Carter
Increase by one the size of wid_list array as index variable can reach a
value of 5. If this happens, an out-of-bounds access is performed.
Addresses-Coverity-ID: 1451981 ("Out-of-bounds access")
Fixes: c5c77ba18ea66 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
---
drivers/staging/wilc1000/hif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc1000/hif.c
index 6c7de2f8d3f2..128943c3be4f 100644
--- a/drivers/staging/wilc1000/hif.c
+++ b/drivers/staging/wilc1000/hif.c
@@ -151,7 +151,7 @@ int wilc_scan(struct wilc_vif *vif, u8 scan_source, u8 scan_type,
void *user_arg, struct cfg80211_scan_request *request)
{
int result = 0;
- struct wid wid_list[5];
+ struct wid wid_list[6];
u32 index = 0;
u32 i, scan_timeout;
u8 *buffer;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wilc1000: Increase the size of wid_list array
2020-05-01 17:02 [PATCH] staging: wilc1000: Increase the size of wid_list array Oscar Carter
@ 2020-05-01 18:26 ` Ajay.Kathat
2020-05-03 7:32 ` Oscar Carter
0 siblings, 1 reply; 3+ messages in thread
From: Ajay.Kathat @ 2020-05-01 18:26 UTC (permalink / raw)
To: oscar.carter, adham.abozaeid
Cc: gregkh, rachel.kim, johnny.kim, chris.park, dean.lee,
linux-wireless, devel, linux-kernel
On 01/05/20 10:32 pm, Oscar Carter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Increase by one the size of wid_list array as index variable can reach a
> value of 5. If this happens, an out-of-bounds access is performed.
>
> Addresses-Coverity-ID: 1451981 ("Out-of-bounds access")
> Fixes: c5c77ba18ea66 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
The code changes are fine. But the correct commit for Fixes tag should be
Fixes: f5a3cb90b802d ("staging: wilc1000: add passive scan support")
Regards,
Ajay
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> ---
> drivers/staging/wilc1000/hif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc1000/hif.c
> index 6c7de2f8d3f2..128943c3be4f 100644
> --- a/drivers/staging/wilc1000/hif.c
> +++ b/drivers/staging/wilc1000/hif.c
> @@ -151,7 +151,7 @@ int wilc_scan(struct wilc_vif *vif, u8 scan_source, u8 scan_type,
> void *user_arg, struct cfg80211_scan_request *request)
> {
> int result = 0;
> - struct wid wid_list[5];
> + struct wid wid_list[6];
> u32 index = 0;
> u32 i, scan_timeout;
> u8 *buffer;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wilc1000: Increase the size of wid_list array
2020-05-01 18:26 ` Ajay.Kathat
@ 2020-05-03 7:32 ` Oscar Carter
0 siblings, 0 replies; 3+ messages in thread
From: Oscar Carter @ 2020-05-03 7:32 UTC (permalink / raw)
To: Ajay.Kathat
Cc: oscar.carter, adham.abozaeid, gregkh, rachel.kim, johnny.kim,
chris.park, dean.lee, linux-wireless, devel, linux-kernel
On Fri, May 01, 2020 at 06:26:10PM +0000, Ajay.Kathat@microchip.com wrote:
>
> On 01/05/20 10:32 pm, Oscar Carter wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Increase by one the size of wid_list array as index variable can reach a
> > value of 5. If this happens, an out-of-bounds access is performed.
> >
> > Addresses-Coverity-ID: 1451981 ("Out-of-bounds access")
> > Fixes: c5c77ba18ea66 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
>
> The code changes are fine. But the correct commit for Fixes tag should be
>
> Fixes: f5a3cb90b802d ("staging: wilc1000: add passive scan support")
>
Sorry for the mistake. I will make the change and I will send a new version.
>
> Regards,
> Ajay
>
> > Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> > ---
> > drivers/staging/wilc1000/hif.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wilc1000/hif.c b/drivers/staging/wilc1000/hif.c
> > index 6c7de2f8d3f2..128943c3be4f 100644
> > --- a/drivers/staging/wilc1000/hif.c
> > +++ b/drivers/staging/wilc1000/hif.c
> > @@ -151,7 +151,7 @@ int wilc_scan(struct wilc_vif *vif, u8 scan_source, u8 scan_type,
> > void *user_arg, struct cfg80211_scan_request *request)
> > {
> > int result = 0;
> > - struct wid wid_list[5];
> > + struct wid wid_list[6];
> > u32 index = 0;
> > u32 i, scan_timeout;
> > u8 *buffer;
> > --
> > 2.20.1
> >
Thanks,
Oscar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-03 7:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01 17:02 [PATCH] staging: wilc1000: Increase the size of wid_list array Oscar Carter
2020-05-01 18:26 ` Ajay.Kathat
2020-05-03 7:32 ` Oscar Carter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).