From: Sam Ravnborg <sam@ravnborg.org>
To: Konrad Dybcio <konradybcio@gmail.com>
Cc: skrzynka@konradybcio.pl,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Add support for TM5P5 NT35596 video mode panel
Date: Fri, 1 May 2020 23:00:38 +0200 [thread overview]
Message-ID: <20200501210038.GB26726@ravnborg.org> (raw)
In-Reply-To: <20200501204825.146424-1-konradybcio@gmail.com>
Hi Konrad.
On Fri, May 01, 2020 at 10:48:21PM +0200, Konrad Dybcio wrote:
> I am aware of the fact that this is probably not the correct
> naming of this panel, yet I am unable to retrieve any additional
> information about it, as it is used in a smartphone to which no
> schematics are released.
>
> The driver has been generated with the help of
> linux-mdss-dsi-panel-driver-generator [1] and works perfectly
> on a Asus Zenfone 2 Laser Z00T smartphone, including brighness
> control and switching on/off.
>
> [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator
Panle driver looks good.
Will take a closer look tomorrow.
Any chance you can work on the TODO in the driver so we can have that
resolved before we apply it?
Also for a v2 it would be perfect if you could work on top of
drm-misc-next.
There is at least one small fix needed to build that I spotted.
But wait until I get back on the driver patch before submitting a v2.
Sam
>
> Konrad Dybcio (2):
> drivers: drm: panel: Add TM5P5 NT35596 panel driver
> dt-bindings: display: Document TM5P5 NT35596 panel compatible
>
> .../bindings/display/panel/tm5p5,nt35596.txt | 7 +
> drivers/gpu/drm/panel/Kconfig | 9 +
> drivers/gpu/drm/panel/Makefile | 1 +
> drivers/gpu/drm/panel/panel-tm5p5-nt35596.c | 366 ++++++++++++++++++
> 4 files changed, 383 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/tm5p5,nt35596.txt
> create mode 100644 drivers/gpu/drm/panel/panel-tm5p5-nt35596.c
>
> --
> 2.26.1
next prev parent reply other threads:[~2020-05-01 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 20:48 [PATCH 0/2] Add support for TM5P5 NT35596 video mode panel Konrad Dybcio
2020-05-01 20:48 ` [PATCH 1/2] drivers: drm: panel: Add TM5P5 NT35596 panel driver Konrad Dybcio
2020-05-02 7:05 ` Sam Ravnborg
[not found] ` <CAMS8qEU7kX8Ts=hJkNNdgV_eOGXv3qG6iDWgjHRNXq3f7qoRuA@mail.gmail.com>
2020-05-02 11:16 ` Sam Ravnborg
2020-05-01 20:48 ` [PATCH 2/2] dt-bindings: display: Document TM5P5 NT35596 panel compatible Konrad Dybcio
2020-05-01 20:54 ` Sam Ravnborg
2020-05-01 21:00 ` Sam Ravnborg [this message]
2020-05-01 21:29 ` [PATCH 0/2] Add support for TM5P5 NT35596 video mode panel Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501210038.GB26726@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konradybcio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skrzynka@konradybcio.pl \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).